Skip to content

Conversation

@kbumsik
Copy link
Contributor

@kbumsik kbumsik commented Aug 19, 2025

No description provided.

@kbumsik kbumsik requested a review from gmlwns2000 August 19, 2025 08:25
@kbumsik kbumsik self-assigned this Aug 19, 2025
Copilot AI review requested due to automatic review settings August 19, 2025 08:25
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This is a release preparation PR for version 1.2.9 that updates the package version and makes configuration adjustments to documentation examples.

  • Updates package version from 1.2.8 to 1.2.9 in pyproject.toml
  • Removes Python 3.9 support by updating minimum Python requirement to 3.10
  • Updates documentation examples with revised context lengths and configuration parameters

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
pyproject.toml Version bump to 1.2.9, drops Python 3.9 support, removes commented Python 3.9 wheel reference
docs/USAGE.sglang.md Updates Docker image tags to v1.2.9, revises context length configurations and adds new tool-call-parser parameters
Comments suppressed due to low confidence (1)

pyproject.toml:74

  • [nitpick] The removal of the Python 3.9 wheel reference is consistent with dropping Python 3.9 support, but consider removing all commented wheel references or keeping them for documentation purposes. The current state has inconsistent commenting patterns.
    # { url = "https://github.com/Dao-AILab/flash-attention/releases/download/v2.7.4.post1/flash_attn-2.7.4.post1+cu12torch2.6cxx11abiFALSE-cp310-cp310-linux_x86_64.whl", marker = "sys_platform == 'linux' and python_version == '3.10'" },

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Collaborator

@gmlwns2000 gmlwns2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!!!

@kbumsik kbumsik changed the title Release: 1.2.9 (WIP) Release: 1.2.9 Aug 19, 2025
@kbumsik kbumsik marked this pull request as draft August 19, 2025 08:27
@kbumsik kbumsik changed the title (WIP) Release: 1.2.9 Release: 1.2.9 Oct 9, 2025
@kbumsik kbumsik marked this pull request as ready for review October 9, 2025 06:34
@kbumsik kbumsik requested a review from gmlwns2000 October 9, 2025 06:35
@kbumsik
Copy link
Contributor Author

kbumsik commented Oct 9, 2025

@gmlwns2000 Docker & Pypi published. Please review this.

Copy link
Collaborator

@gmlwns2000 gmlwns2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Legend!

@kbumsik kbumsik merged commit 4c30ec0 into deepauto/dev Oct 9, 2025
1 check passed
@kbumsik kbumsik deleted the feat/1-2-9 branch October 9, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants