-
Notifications
You must be signed in to change notification settings - Fork 15
Release: 1.2.9 #80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release: 1.2.9 #80
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This is a release preparation PR for version 1.2.9 that updates the package version and makes configuration adjustments to documentation examples.
- Updates package version from 1.2.8 to 1.2.9 in pyproject.toml
- Removes Python 3.9 support by updating minimum Python requirement to 3.10
- Updates documentation examples with revised context lengths and configuration parameters
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pyproject.toml | Version bump to 1.2.9, drops Python 3.9 support, removes commented Python 3.9 wheel reference |
| docs/USAGE.sglang.md | Updates Docker image tags to v1.2.9, revises context length configurations and adds new tool-call-parser parameters |
Comments suppressed due to low confidence (1)
pyproject.toml:74
- [nitpick] The removal of the Python 3.9 wheel reference is consistent with dropping Python 3.9 support, but consider removing all commented wheel references or keeping them for documentation purposes. The current state has inconsistent commenting patterns.
# { url = "https://github.com/Dao-AILab/flash-attention/releases/download/v2.7.4.post1/flash_attn-2.7.4.post1+cu12torch2.6cxx11abiFALSE-cp310-cp310-linux_x86_64.whl", marker = "sys_platform == 'linux' and python_version == '3.10'" },
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
gmlwns2000
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!!!!
|
@gmlwns2000 Docker & Pypi published. Please review this. |
gmlwns2000
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Legend!
No description provided.