Refactoring 2: Pass profiles across conversion methods instead of flags.#5
Open
Deep1998 wants to merge 4 commits intorefactor-src-profilefrom
Open
Refactoring 2: Pass profiles across conversion methods instead of flags.#5Deep1998 wants to merge 4 commits intorefactor-src-profilefrom
Deep1998 wants to merge 4 commits intorefactor-src-profilefrom
Conversation
* Fix quoting * Added null and float handling * Added comment
…o utils (GoogleCloudPlatform#248) * Refactorings except common.gp * Just common.go changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change ensures we pass Source Profile and Target Profile across the SchemaConv and Data conv functions.
We also store driver and targetdb in source and target profiles respectively.
This is branches off from refactoring 1 branch so changes are relative to that.