-
Notifications
You must be signed in to change notification settings - Fork 6
Check mappings #187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Check mappings #187
Conversation
|
with the latest commit, I fully removed rocq compile warnings (for example during vo). |
|
I had to add a dependency to lambdapi as I use the parser. |
|
@fblanqui fun fact: now that I check objects from all relevant files including theory_hol.lp, I found out that ∃ᵢ had a small error by having an untyped parameter t which was therefore wrongly assumed to be of type Set (Type') upon export. This was not an actual problem as it is always mapped and thus not actually translated as is, but maybe it could have been an issue for translation to other proof systems. |
|
Why do you see this as an error? Note there are other symbols for which the argument A or a has no explicit type given. The problem seems rather about t after your change in this PR, right? |
I am not sure to understand. What I meant is that lampdapi export to stt-coq automatically assumes the type of untyped parameters to be Type', which is correct for all automatically generated files. theory_hol.lp is the only non-automatically generated file that is translated, and in this file I believe this t is the only untyped parameter (or at least the only one not of type Type'), which is indeed not a problem since this axiom is mapped and thus not translated. in 6af45f1 I explicitly typed it, just in case, so that even if this axiom is unmapped, the proofs could compile. |
4c44fa4 to
4632117
Compare
fblanqui
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi. I had a quick look at this PR and made a few comments. Could you please make the requested changes?
4632117 to
eaff15f
Compare
|
CI now succeeds |
- Now added an error for when a Definition is mapped but not the corresponding Lemma, or the opposite - Now added a warning for unmapped axioms.
13a97b8 to
4ef1781
Compare
Related to issue #178.
Adds command "make check-mappings" to check the correctness of the mappings, printing errors for wrong mappings.
It is done by translating the theory_hol.lp, $(base)_types.lp and $(base)_terms.lp files by adapting the lambdapi export code (in file xmapcheck.ml) and uses both ocaml checks and calls to Rocq's typechecker.
It can automatically diagnose all the following at once :
Notes: