feat: Exposes SDK validation on models names #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdirAmsalem
reviewed
Dec 18, 2025
packages/sdk/src/index.ts
Outdated
Comment on lines
34
to
38
| realtimeModels, | ||
| videoModels, | ||
| imageModels, | ||
| modelSchema, | ||
| modelInputSchemas, |
Contributor
There was a problem hiding this comment.
Do we want to expose this for the isRealtime/isVideo/isImage checks?
Exposing the Zod schemas directly would make Zod - and these specific schemas - part of our public API, which I'm not sure is ideal. It would only benefit our Zod-based consumers, and limit our ability to evolve the schemas freely or, if needed, change Zod in favor of something else in the future.
What do you think? Maybe we should expose more targeted, explicit checks instead?
VerioN1
force-pushed
the
feautre/export-zod-schemas
branch
from
7e2ff1c to
f2fbe5e
Compare
commit: |
Contributor
Author
|
fixed @AdirAmsalem |
AdirAmsalem
reviewed
Dec 18, 2025
packages/sdk/src/index.ts
Outdated
| isVideoModel, | ||
| type Model, | ||
| type ModelDefinition, | ||
| modelSchema, |
packages/sdk/src/index.ts
Outdated
| type VideoModels, | ||
| } from "./shared/model"; | ||
| export type { ModelState } from "./shared/types"; | ||
| export { type ModelState, modelStateSchema } from "./shared/types"; |
AdirAmsalem
approved these changes
Dec 18, 2025
VerioN1
changed the title
VerioN1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes important Zod validation schemas from the SDK.
Enables external consumers to leverage these schemas for consistent data validation, including various model definitions and model state.
Note
Adds
isRealtimeModel,isVideoModel, andisImageModelhelpers and exports them from the SDK.packages/sdk/src/index.ts):isRealtimeModel,isVideoModel,isImageModelfrom./shared/model.packages/sdk/src/shared/model.ts):isRealtimeModel,isVideoModel,isImageModel.Written by Cursor Bugbot for commit ce04941. This will update automatically on new commits. Configure here.