added prompt ack event and updated setPrompt #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VerioN1
force-pushed
the
api-460-sdks-let-devs-know-when-their-prompt-was-applied-in-realtime
branch
from
b0baa47 to
09e8365
Compare
VerioN1
force-pushed
the
api-460-sdks-let-devs-know-when-their-prompt-was-applied-in-realtime
branch
from
81511cf to
53694d6
Compare
AdirAmsalem
reviewed
Nov 30, 2025
decart/realtime/client.py
Outdated
| logger.exception(f"Error in error callback: {e}") | ||
|
|
||
| async def set_prompt(self, prompt: str, enrich: bool = True) -> None: | ||
| async def set_prompt(self, prompt: str, enrich: bool = True, max_timeout: float = 15.0) -> None: |
Contributor
There was a problem hiding this comment.
we want to expose max_timeout in python? we kept this internal in the js sdk
Contributor
Author
There was a problem hiding this comment.
didn't saw that it was exposed, removed it
AdirAmsalem
approved these changes
Nov 30, 2025
VerioN1
force-pushed
the
api-460-sdks-let-devs-know-when-their-prompt-was-applied-in-realtime
branch
from
46426b9 to
6247529
Compare
VerioN1
deleted the
api-460-sdks-let-devs-know-when-their-prompt-was-applied-in-realtime
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.