Skip to content

feat: allow skip inline comment strip logic#19

Merged
DeanPDX merged 1 commit intoDeanPDX:mainfrom
dafanasiev:main
Dec 3, 2025
Merged

feat: allow skip inline comment strip logic#19
DeanPDX merged 1 commit intoDeanPDX:mainfrom
dafanasiev:main

Conversation

@dafanasiev
Copy link
Contributor

subj

@codecov
Copy link

codecov bot commented Dec 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (5cb3a94) to head (069003f).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #19   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          138       142    +4     
=========================================
+ Hits           138       142    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DeanPDX
Copy link
Owner

DeanPDX commented Dec 3, 2025

LGTM with one caveat. I think this might be better handled with better string escaping:

# This currently works because we are checking for " #".
APP_URL="https://myapp.com/#someAnchor"
# This currently does NOT work, but with better string escaping it could.
APP_ACTION="Take a #"

I will create a task to improve string escaping.

@DeanPDX DeanPDX merged commit 9b64e05 into DeanPDX:main Dec 3, 2025
3 checks passed
@DeanPDX DeanPDX mentioned this pull request Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments