Skip to content

Add map name to replay viewer#152

Merged
DeamonHunter merged 3 commits intoDeamonHunter:masterfrom
Dune-jr:issue133-mapinfo-on-replays
Apr 19, 2025
Merged

Add map name to replay viewer#152
DeamonHunter merged 3 commits intoDeamonHunter:masterfrom
Dune-jr:issue133-mapinfo-on-replays

Conversation

@Dune-jr
Copy link
Contributor

@Dune-jr Dune-jr commented Feb 26, 2025

Closes #133

Description

This adds a "Map: XXX" label in the simplest way possible. I do not have design skills, so maybe you want to improve on that - put it in a box or something.

  • I had to pass the TerrainName information around in the code, maybe 1b7d182 could have been lighter but I did not find a way how.
  • Tiny changes because of some warnings and lenghty parameters list giving me a headache - addd7af and 04a5552. They can be dropped if you prefer.

Screenshot

image

@Dune-jr Dune-jr changed the title Issue133 mapinfo on replays Add map name to replay viewer Feb 26, 2025
@Dune-jr
Copy link
Contributor Author

Dune-jr commented Feb 26, 2025

Thinking of it, probably we want this to be a setting that can be turned on and off? I see the tool is extensively customizable.

@DeamonHunter DeamonHunter merged commit 245879f into DeamonHunter:master Apr 19, 2025
1 check failed
@DeamonHunter
Copy link
Owner

Hi sorry for taking so long to get to this. I had some issues in life (Kidney stone for one), and ended up forgetting about this.

Thanks for doing this however. I'll try to get a build out at some point, but I would need to get my old PC hooked up to get build files for my mac.

@Dune-jr
Copy link
Contributor Author

Dune-jr commented Apr 19, 2025

Christ that sucks :/
Can't we get CI to build it?

@Dune-jr Dune-jr deleted the issue133-mapinfo-on-replays branch April 19, 2025 13:34
@DeamonHunter
Copy link
Owner

I need to double check things, If I pushed the right file, it might be setupable. Its a bit jank.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request: Map information on replays

2 participants