docs: add Windows build prerequisites#107
Open
Jevari wants to merge 1 commit intoDeadWaveWave:mainfrom
Open
Conversation
Owner
|
感谢补充 Windows 构建前置条件,方向是对的(先用文档兜住 #102 里提到的问题)。 合并前想确认:这些步骤你是否在真实 Windows 环境里验证通过?麻烦把【实际环境】和【验证步骤】补充到 PR 描述(或在这里回一条也可以),方便其他人复现。 实际环境(请按真实情况填写)
验证步骤(请写你实际跑过的命令)
另外一个小点:Note 里目前写“older node-gyp 可能无法正确检测 VS 2022 (v17)”。我理解主要风险是 VS 2025/2026 (v18) 在较老 node-gyp 里不被识别;如果你确认是这个情况,建议把 wording 改得更明确,避免误导。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows up on #94 (closed) and the issue tracked in #102.
What this adds
A Windows-specific prerequisites section in CONTRIBUTING.md covering:
No code changes
Doc only — zero impact on CI or runtime behavior.