Merged
Conversation
Test Results163 tests 163 ✅ 14s ⏱️ Results for commit c35a5cb. ♻️ This comment has been updated with latest results. |
seokhwan-an
commented
May 5, 2025
Collaborator
Author
seokhwan-an
left a comment
seokhwan-an
left a comment
There was a problem hiding this comment.
수정 및 추가로 반영해야할 부분 추가
Comment on lines
+12
to
+13
| DEMO_DAY_IS_CLOSED(HttpStatus.BAD_REQUEST, 5005, "데모데이가 종료되었습니다."), | ||
| DEMO_DAY_OWNER_NOT_APPLY_ONESELF(HttpStatus.BAD_REQUEST, 5005, "자신이 등록한 데모데이에는 신청할 수 없습니다."), |
Collaborator
Author
There was a problem hiding this comment.
error code의 값이 같은데 수정 필요
Comment on lines
+108
to
+118
| if (this.status == Status.CLOSED) { | ||
| throw new DemoDayException(DemoDayErrorCode.DEMO_DAY_IS_CLOSED); | ||
| } | ||
|
|
||
| if (Objects.equals(user.getId(), this.userId)) { | ||
| throw new DemoDayException(DemoDayErrorCode.DEMO_DAY_OWNER_NOT_APPLY_ONESELF); | ||
| } | ||
|
|
||
| if (ticket.getCapacity() == 0) { | ||
| throw new DemoDayException(DemoDayErrorCode.DEMO_DAY_IS_FULL); | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
동일한 사람이 같은 demo day에 여러번 신청하더라도 문제가 발생하지 않는 상황이 존재하고 그 부분에 대한 예외처리가 필요
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 작업 내용
💬 작업 시 고민사항
고민사항
#️⃣ 연관된 이슈