Feature #90 : 특정 기수의 특정 기간동안 작성한 book log의 개수를 조회하는 api 추가#93
Merged
seokhwan-an merged 8 commits intodevelopfrom Apr 29, 2025
Merged
Feature #90 : 특정 기수의 특정 기간동안 작성한 book log의 개수를 조회하는 api 추가#93seokhwan-an merged 8 commits intodevelopfrom
seokhwan-an merged 8 commits intodevelopfrom
Conversation
Test Results156 tests 156 ✅ 10s ⏱️ Results for commit bd3d86c. ♻️ This comment has been updated with latest results. |
seokhwan-an
commented
Apr 29, 2025
Collaborator
Author
seokhwan-an
left a comment
seokhwan-an
left a comment
There was a problem hiding this comment.
작업한 코드를 보고 수정해야하는 점 체크 후 반영하기
|
|
||
| public UserBookLogCountInWeekResponse getUserBookLogCountInWeek(final int generation, final String start, final String end) { | ||
| final LocalDateTime startDate = LocalDate.parse(start).atStartOfDay(); | ||
| final LocalDateTime endDate = LocalDate.parse(end).atTime(23, 59, 59); |
Collaborator
Author
There was a problem hiding this comment.
현재 booklog는 마이크로 초까지 저장이 되기 때문에 endDate가 지금처럼 설정되면 23시59분59.xxxx초 에 대해서는 불러오지 못하는 문제가 될 수 있을 것 같다
Collaborator
Author
There was a problem hiding this comment.
그리고 해당 요청에서 파라미터 값 검증이 필요할 것 같습니다.
- 기수가 음수인 경우는 없어야 한다.
- startDate가 endDate 이하여야 한다.
Comment on lines
+20
to
+21
| public Role convertToEntityAttribute(String s) { | ||
| if (s == null) { |
Collaborator
Author
There was a problem hiding this comment.
파라미터 명칭을 s 대신에 의미 있는 명칭으로 수정하는 것이 좋을 것 같다.
예를 들면 roleType이 적절한 것 같다.
seokhwan-an
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 작업 내용
요구사항 : 일주일 마다 회원을 필수적으로 4개의 book log를 작성해야한다 -> 관리자는 해당 정보를 파악할 수 있어야 한다.
💬 작업 시 고민사항
#️⃣ 연관된 이슈