Palico editor overhaul/bug fix, plus misc offset/function corrections#13
Open
iSharingan wants to merge 33 commits intoDawnshifter:masterfrom
Open
Palico editor overhaul/bug fix, plus misc offset/function corrections#13iSharingan wants to merge 33 commits intoDawnshifter:masterfrom
iSharingan wants to merge 33 commits intoDawnshifter:masterfrom
Conversation
Remove cat import equipment reset bug. Previously it would set weapon to slot 2 (0x0001) of the palico item box and armor to slot 1 (0x0000), which could crash the game if the active AI palicos or active prowler had a weapon in the armor slots, armor in the weapon slot, and/or no weapon was equipped
Corrected several data sizes to (hopefully) correct display/edit errors for shoutouts.
Changes conditional for presence of palico to the palico ID instead of the first byte of the name (since its possible to import null name cats and lose access to fix it on later loads of the save), updates the accepted name length to prevent 32 byte names from not including a zero-terminator (results in garbage text after the name otherwise, as other data is included in the name string in-game), and perfects the DLC cat check. TL;DR: Null name cats can now be fixed. DLC status for cats always display correctly, and no more garbage text in long cat names
Corrected/translated palico skill names (and sorting). Made DLC skills more visible as such to limit accidental useless/illegal cat creation. Corrected/translated palico support move names and added T[eachable] group to allow editing taught moves (teachable move/skill editing not yet implemented. Skills will reuse the general skill group since all skills can be taught if the cat doesn't already know them) Update arena palico bias entry data Note: there still appears to be an unhandled Charisma cat support move RNG pattern, but I don't have the cat with the problem anymore to find the exact RNG value/pattern to add
Corrected arena time entry field's label. The time is stored in frames, not seconds. Ironically the game tracks this as if its 60 FPS despite the game actually being throttles to a fixed 30 FPS
Turned off auto-update of arena rank since several arenas have 7 minute limits for S instead of the usual 5. Its safe to assume if they're editing arena times, they'll also manually change the rank to match.
size comment update on shoutouts for consistency
Update shoutout read/write sizes to (hopefully) display them correctly. Starting offset is likely wrong too (will be addressed in another commit if so)
Corrected Shoutout offsets
Corrected Health Harmonics to Horn Virtuoso
Updated options for learned skills/actions to allow better sanity checks/manual corrections when editing and importing cats overhauled skill and action reset functions to actually correct skills/actions when changing bias instead of only clearing the pattern slots (previously resulting in various bugs/unchanged skills)
for build test
to keep test version separate from other releases
commented out line 1580. Unsure of purpose (no context, comments or variable naming convention), but clearly an incomplete function.
further corrections while attempting build
Syntax corrections, minor formatting changes, reverted a previous commit that cause problems (palico name import size)
"finalize" editor version number/name, repair/replace skill and action validation functions, add event to forte change that resets skills/actions for new build (minimizes chance at accidentally creating illegal cats), build tested and verified all new code functions as intended (though I'm sure *someone* will still find a way to break it eventually)
This was referenced Feb 10, 2022
Add DLC flag checkbox/edit capabilities to cats, add missing palico status options, Refactored save loading message box to not need additional message windows, updates minor tool/build/source info, removes sign manifests to reduce "build failed" errors for missing certificates when building on other machines
Finished renaming for the intended primary save type (primarily cosmetic). repaired one last build issue (executable built fine before, but reported errors. now it fully complete successfully)
Saving/loading now works fully as intended (previously threw an error if you performed two save operations without a load in between)
Version increased to 1.1.0, reflecting the previous commit's fix
Author
|
With one of the latest commits (4524bcd) saving/loading now works fully as intended (previously threw an error if you performed two save operations without a load in between) |
spelling correction/DLC clarification on Jugido skill
- translated palico weapon names to English - corrected minor misspellings in support action names that occasionally lead to a crash after saving a cat that was edited to have the affected actions - adjusted check for hired cats to the second byte of the Action RNG for better reliability in case of null cat name or palico ID of 0 - bias-related and fixed actions/skills now automatically populate in the corresponding learned lists when editing a cat's bias or RNG patterns - iterated version number
Exactly as advertised
- Palico helmet/armor colors can now be edited - Palico colors are now reflected in the background of the respective labels so the result can be previewed - Adds note for helmet/armor color edit limitations
corrects missed adjustment to account for taught actions when changing action RNG (could manually be corrected prior via dropdown)
- corrected spelling of "Transpurrter" in several spots to remove crash - added reminder to add fixed bias actions to equipped action list
Sanity check added to color conversion for palico color previews to ensure errors don't occur if color value is too short
Corrected crashes involving Rath-of-Meow in an A tier slots and Far-Cat-Ster in B tier slots. All support actions have now been tested.
Added sanity check when importing action/support moves to prevent any future crashes when reading a bad ID
Github is now retarded. Use another platform
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issues with the Shoutout editing functions (now displays/edits correctly), makes minor arena edit changes (no longer auto-incorrects rank letter when editing completion time), and overhauls the Palico editing system to remove various bugs/crashes and increase ease of use while vastly decreasing the chance of creating an illegal cat (illegal cats lose all their actions/skills on quest start when detected by the game). Also fixes a glaring issue when importing *.catzx files that could brick your save should you import over an active cat (even if the imported cat was for the same cat that had just been exported)