Skip to content

feat: Seperate useProvideStore from Provide Wrapper #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
casamia918 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: Seperate useProvideStore from Provide Wrapper #20

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 21 additions & 14 deletions packages/store/src/create-store-context/create-store-context.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,31 +32,37 @@ export function createStoreContext<TCreator extends StoreApi<any, any> | AnyFn>(

const Context = React.createContext<StoreInstance | null>(null);

const Provider = (
props: {
children: React.ReactNode;
} & StoreParams
) => {
const { children, ...restProps } = props;
const storeInstance = React.useRef<StoreInstance>(
createInstance(restProps as StoreParams)
const useProvideStore = (props: StoreParams) => {
const storeInstanceRef = React.useRef<StoreInstance>(
createInstance(props)
);

React.useEffect(() => {
const instance = storeInstance.current;
const instance = storeInstanceRef.current;
if (!instance) return;

const effectMethods = createEffectMethods(instance as any);

effectMethods.subscribeToEffects();

return () => {
effectMethods.unsubscribeFromEffects();
};
}, []);

return storeInstanceRef.current;
};

const Provider = (
props: {
children: React.ReactNode;
} & StoreParams
) => {
const { children, ...restProps } = props;
const storeInstance = useProvideStore(restProps as StoreParams);

return (
<Context.Provider value={storeInstance.current as StoreInstance}>
<Context.Provider value={storeInstance}>
{children}
</Context.Provider>
);
Expand Down Expand Up @@ -91,6 +97,7 @@ export function createStoreContext<TCreator extends StoreApi<any, any> | AnyFn>(

return {
Provider,
useProvideStore,
useStore,
withProvider,
Context,
Expand Down