Skip to content

Bugfix/corrections #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tbanze merged 21 commits into from
Sep 19, 2025
Merged

Bugfix/corrections #7

tbanze merged 21 commits into from
Sep 19, 2025

Conversation

@JonasApelt
Copy link
Contributor

@JonasApelt JonasApelt commented Sep 5, 2025

Fix: federal_state handling, GeoDataFrame import, and debug improvements" \

  • Added missing GeoDataFrame import in relevant modules
  • Adjusted create_grid() to handle power_levels correctly
  • Fixed issue in _target_by_federal_state():
    • Accepts input as string or list
    • Improved error message when state not found
  • Verified available federal_state names in shapefile
  • Added debug logging for power_levels and node creation
  • Ensured skipping of unused transformer creation is explicit
  • Prepared code for pull request against develop branch"

@JonasApelt
Copy link
Contributor Author

JonasApelt commented Sep 5, 2025

Hi Tobias, I changed some minor stuff.

tbanze
tbanze reviewed Sep 6, 2025
View reviewed changes
Copy link
Contributor

@tbanze tbanze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Jonas, danke für deine Verbesserungen. Ich habe dir ein paar Kommentare hinterlassen, kannst du die bitte noch beantworten / einpflegen.

keyfile Outdated
Copy link
Contributor

@tbanze tbanze Sep 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datei wird nicht benötigt, bitte löschen

Copy link
Contributor Author

@JonasApelt JonasApelt Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ist gelöscht

keyfile.pub Outdated
Copy link
Contributor

@tbanze tbanze Sep 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datei wird nicht benötigt, bitte löschen

Copy link
Contributor Author

@JonasApelt JonasApelt Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ist gelöscht

examples/create_grid_model.ipynb
Copy link
Contributor

@tbanze tbanze Sep 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hast du etwas an dem Tutorial geändert? Wenn du es nur durchlaufen lassen hast, dann bitte Änderungen nicht in PR mit rein nehmen

src/dave_core/model_utils.py Outdated
# create nodes
import networkx as nx

graph = nx.Graph()
Copy link
Contributor

@tbanze tbanze Sep 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warum das ganze package laden anstatt einzelner funktionen?

src/dave_core/model_utils.py
OUTPUT:
**nodes** (set) - all dave names for nodes which are not connected to a grid with a minumum
number of nodes \n
Identify disconnected nodes in a network.
Copy link
Contributor

@tbanze tbanze Sep 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warum Input und Output aus dem docstring gelöscht?

@tbanze tbanze merged commit f05369f into DaveFoss:main Sep 19, 2025
6 of 8 checks passed
@coveralls
Copy link

coveralls commented Sep 19, 2025

Pull Request Test Coverage Report for Build 17852539765

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 18 of 113 (15.93%) changed or added relevant lines in 9 files are covered.
  • 20 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-0.2%) to 29.466%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/dave_core/create.py 0 1 0.0%
src/dave_core/components/transformers.py 0 2 0.0%
src/dave_core/geography/target_area.py 0 2 0.0%
src/dave_core/components/loads.py 1 9 11.11%
src/dave_core/toolbox.py 9 19 47.37%
src/dave_core/io/file_io.py 4 15 26.67%
src/dave_core/model_utils.py 1 62 1.61%
Files with Coverage Reduction New Missed Lines %
src/dave_core/components/power_plants.py 1 3.72%
src/dave_core/geography/target_area.py 1 41.95%
datapool/test_download.py 1 96.0%
src/dave_core/components/loads.py 5 9.5%
src/dave_core/model_utils.py 5 13.02%
src/dave_core/components/transformers.py 7 5.63%
Totals Coverage Status
Change from base Build 17328277913: -0.2%
Covered Lines: 1696
Relevant Lines: 5399
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tbanze tbanze tbanze approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JonasApelt @coveralls @tbanze