-
-
Notifications
You must be signed in to change notification settings - Fork 9
Simplify color API: use #DDF4FF default and eliminate bootstrap color classes #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Co-authored-by: DataStrategist <8094091+DataStrategist@users.noreply.github.com>
Co-authored-by: DataStrategist <8094091+DataStrategist@users.noreply.github.com>
|
Too compicated. Simplify your implementation a lot... for example, the default color for buttons should be: |
Co-authored-by: DataStrategist <8094091+DataStrategist@users.noreply.github.com>
…FF, update tests Co-authored-by: DataStrategist <8094091+DataStrategist@users.noreply.github.com>
…tstrap classes Co-authored-by: DataStrategist <8094091+DataStrategist@users.noreply.github.com>
I've simplified the implementation significantly as requested. The changes include:
The API is now much cleaner: all color parameters accept actual color values (hex, named, rgb) and the default is the pleasant Commit: cfd0f01 |
This PR dramatically simplifies the TileMaker color API by removing complex bootstrap color detection logic and standardizing on actual color values.
Key Changes
1. New Default Color
All box functions now use
#DDF4FFas the default color instead of bootstrap class names:2. Eliminated Bootstrap Color Classes
Removed all references to bootstrap color terminology ("primary", "success", "warning", etc.). The API now only accepts actual color values:
3. Simplified Implementation
is_bootstrap_color()helper functionpanel panel-defaultwithbackground-colorCSS4. Preserved Gradient Functionality
solo_gradient_boxretains its pleasant pastel color system:#C8E6C9(pastel green)#FFF9C4(pastel yellow)#FFCDD2(pastel red)5. Text Color Control
The
text_colorparameter continues to work for independent text styling:Technical Benefits
#DDF4FFinstead of generic bootstrap blueBackward Compatibility
This is a breaking change for code using bootstrap color class names. Migration is straightforward:
Fixes #25.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.