-
Notifications
You must be signed in to change notification settings - Fork 4
feat(emails): implement send email functionality #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
SlimDeluxe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- For the message, allow rich text / WYS editor
- Sender (user) email should be set as the "reply to" address
- Refactor actions: a) move stuff from the trait to
SendEmailActionclass and delete the trait, b)SendEmailTableActionshould extendSendEmailActionand overload themakemethod
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #18 +/- ##
============================================
- Coverage 74.50% 73.10% -1.41%
- Complexity 225 289 +64
============================================
Files 45 54 +9
Lines 1377 1848 +471
============================================
+ Hits 1026 1351 +325
- Misses 351 497 +146 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works!
You can now work on the details
- Move the nav link to Tools, after "Application Health"
- When using the log as mailer, the listener does not appear to work. Is it tricky to set up also for log?
- The mail log table should be full width (see catalogue products table)
- Some columns are not visible in the UI
- Remove unnecessary permissions for mail log resource
See below for code comments
what do you mean with this? if you mean |
|
Yes that's what I mean, but it wasn't working for me 😐 Maybe I forgot to restart horizon, I'll try again. |
should be fixed now |


No description provided.