Skip to content

Conversation

@thapacodes4u
Copy link
Contributor

@thapacodes4u thapacodes4u commented Sep 26, 2025

Related ticket

Improved.Media.Gallery.Form.Field.Demo.mp4

@thapacodes4u
Copy link
Contributor Author

@SlimDeluxe I will put this to draft for now. Maybe wait till its migrated to v4

@thapacodes4u thapacodes4u marked this pull request as draft September 26, 2025 08:20
@thapacodes4u thapacodes4u marked this pull request as ready for review September 26, 2025 08:46
@thapacodes4u thapacodes4u marked this pull request as draft September 26, 2025 08:46
@thapacodes4u thapacodes4u marked this pull request as ready for review October 5, 2025 14:51
@thapacodes4u
Copy link
Contributor Author

@SlimDeluxe since we won't be merging F4 anytime soon so maybe this can be reviewed & merged.

@SlimDeluxe
Copy link
Member

@thapacodes4u please merge from main and resolve the conflct.

@thapacodes4u
Copy link
Contributor Author

@SlimDeluxe Ready for review

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 22.45322% with 746 lines in your changes missing coverage. Please review.
✅ Project coverage is 20.98%. Comparing base (330c775) to head (6c090c5).

Files with missing lines Patch % Lines
src/Filament/Forms/Components/MediaGallery.php 13.93% 729 Missing ⚠️
...ment/Forms/Components/Concerns/HasMediaPreview.php 85.00% 9 Missing ⚠️
...orms/Components/Concerns/HasMediaUploadOptions.php 82.22% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main       #7      +/-   ##
============================================
+ Coverage     15.74%   20.98%   +5.23%     
- Complexity       89      318     +229     
============================================
  Files            13       17       +4     
  Lines           254     1215     +961     
============================================
+ Hits             40      255     +215     
- Misses          214      960     +746     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SlimDeluxe SlimDeluxe merged commit 76d9725 into DataLinx:main Oct 8, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants