Skip to content

Fix / Menu Tests Failing #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SlimDeluxe merged 2 commits into from
Oct 22, 2025
Merged

Fix / Menu Tests Failing #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d2eb039
fix: resolve intermittent menu test failures and translation display …
thapacodes4u Oct 8, 2025
a29db6f
Merge branch 'main' of https://github.com/DataLinx/eclipsephp-cms-plu…
thapacodes4u Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/Models/Page.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,18 @@
use Illuminate\Database\Eloquent\Model;
use Illuminate\Database\Eloquent\Relations\BelongsTo;
use Illuminate\Database\Eloquent\SoftDeletes;
use Spatie\Translatable\HasTranslations;

class Page extends Model
{
use HasFactory, SoftDeletes;
use HasFactory, HasTranslations, SoftDeletes;

protected $table = 'cms_pages';

public array $translatable = [
'title',
];

protected $fillable = [
'title',
'section_id',
Expand Down
14 changes: 11 additions & 3 deletions src/Models/Section.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,17 +7,25 @@
use Illuminate\Database\Eloquent\Factories\HasFactory;
use Illuminate\Database\Eloquent\Model;
use Illuminate\Database\Eloquent\SoftDeletes;
use Spatie\Translatable\HasTranslations;

class Section extends Model
{
use HasFactory, SoftDeletes;
use HasFactory, HasTranslations, SoftDeletes;

protected $table = 'cms_sections';

protected $casts = [
'type' => SectionType::class,
public array $translatable = [
'name',
];

protected function casts(): array
{
return [
'type' => SectionType::class,
];
}

public function getFillable()
{
$attr = [
Expand Down
18 changes: 9 additions & 9 deletions tests/Unit/MenuItemTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,8 @@

it('can have parent and children relationships', function () {
$menu = Menu::factory()->create();
$parent = Item::factory()->create(['menu_id' => $menu->id]);
$child = Item::factory()->create(['menu_id' => $menu->id, 'parent_id' => $parent->id]);
$parent = Item::factory()->active()->create(['menu_id' => $menu->id]);
$child = Item::factory()->active()->create(['menu_id' => $menu->id, 'parent_id' => $parent->id]);

$childWithParent = Item::withoutGlobalScopes()->with('parent')->find($child->id);
expect($childWithParent->parent)->toBeInstanceOf(Item::class)
Expand Down Expand Up @@ -195,8 +195,8 @@

it('can get tree formatted name', function () {
$menu = Menu::factory()->create();
$parent = Item::factory()->create(['menu_id' => $menu->id, 'label' => 'Parent']);
$child = Item::factory()->create(['menu_id' => $menu->id, 'parent_id' => $parent->id, 'label' => 'Child']);
$parent = Item::factory()->active()->create(['menu_id' => $menu->id, 'label' => 'Parent']);
$child = Item::factory()->active()->create(['menu_id' => $menu->id, 'parent_id' => $parent->id, 'label' => 'Child']);

$parentFormatted = $parent->getTreeFormattedName();
$childFormatted = $child->getTreeFormattedName();
Expand All @@ -207,11 +207,11 @@

it('can get full path', function () {
$menu = Menu::factory()->create();
$parent = Item::factory()->create([
$parent = Item::factory()->active()->create([
'menu_id' => $menu->id,
'label' => ['en' => 'Parent Label'],
]);
$child = Item::factory()->create([
$child = Item::factory()->active()->create([
'menu_id' => $menu->id,
'parent_id' => $parent->id,
'label' => ['en' => 'Child Label'],
Expand All @@ -236,9 +236,9 @@

it('deleting parent item cascades to delete children', function () {
$menu = Menu::factory()->create();
$parent = Item::factory()->create(['menu_id' => $menu->id]);
$child1 = Item::factory()->create(['menu_id' => $menu->id, 'parent_id' => $parent->id]);
$child2 = Item::factory()->create(['menu_id' => $menu->id, 'parent_id' => $parent->id]);
$parent = Item::factory()->active()->create(['menu_id' => $menu->id]);
$child1 = Item::factory()->active()->create(['menu_id' => $menu->id, 'parent_id' => $parent->id]);
$child2 = Item::factory()->active()->create(['menu_id' => $menu->id, 'parent_id' => $parent->id]);

expect(Item::withoutGlobalScopes()->where('parent_id', $parent->id)->count())->toBe(2);
expect($child1->trashed())->toBeFalse();
Expand Down