Skip to content

Conversation

@shubhanshu-gupta
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@whatevergeek whatevergeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @shubhanshu-gupta ,
thanks for the PR.

are you able to to modify the code to just have the following function signature?

def clean_col_management(input_data):
"""
Clean values in column: "status"
Trello card: https://trello.com/c/HHzNs0hS/1-column-countryname
"""
cleaned_data = input_data

do some cleanin on cleaned_data

return cleaned_data

it's interesting to provide filenames when calling from commandline.
on the otherhand, for testing, we shouldn't be calling this file directly.
we should be calling it from test_clean_wpdx_sample_data.py
speaking of which, can you also submit your updated test_clean_wpdx_sample_data.py file?
this should contain a test function that tests your clean_col_management function

thanks for your help on this.
feel free to let me know if you have further clarifications :-)

@whatevergeek
Copy link
Collaborator

sorry for the bold... it should be a comment... i think github translated the python comment into markdown bold :-P

@whatevergeek
Copy link
Collaborator

hi @shubhanshu-gupta ,
any update on this?
let me know what's the plan or if you'd like other volunteers to continue on this.

have a great day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants