Skip to content

Conversation

@robothormones
Copy link

  1. Convert to Int
  2. Throw a error message but leave unchanged if the install year > current year

Copy link
Collaborator

@whatevergeek whatevergeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @robothormones ,
Thanks for the help on this.
Please find my review comments below:

File: data_cleaning/clean_wpdx_sample_data.py

  1. Please update the clean_col_install_year function to use its corresponding trello link. It's currently pointing to countryname
  2. Having validations is great. We should do it. This file is only intended as a cleanup script. We should be separating validation and cleanup. Perhaps, run a validation script then cleanup script as part of a pipeline. That said, kindly create an issue on this github repo to have a facility script for validations.
    For this file, please limit the changes to only cleanup/transformation changes. If none, just archive the scripts (e.g. in a trello card) and reference it when filing the github issue for validation scripts.

Thanks again for your help.
Please reach out to me if there's any clarification, etc.

@whatevergeek
Copy link
Collaborator

fyi.. i've moved the main card to done as there's another PR that cleaned it
but feel free to comment here or in the card for further improvements:
https://trello.com/c/KjLEFR24/8-column-installyear

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants