Audience is now Array based #5
Merged
+50
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianvv
suggested changes
Dec 18, 2025
julianvv
left a comment
julianvv
left a comment
There was a problem hiding this comment.
The encoding makes sense, but I think it would be easier to add the Pos(" ", sAud) check to the Procedure Set Audience. This way the logic for all applications that currently implement this library will remain the same for setting the audience by simply calling Set Audience of oJWT to "Something SomethingElse". Also the return type for Function Audience could stay a string so we simply use a space-separated string.
Made it in a way that it still returns a string.
Collaborator
Author
DAE-RobinHazewinkel
left a comment
DAE-RobinHazewinkel
left a comment
There was a problem hiding this comment.
Made it, backwards compatible by returning a space separated string.
DataFlex-dev
approved these changes
Dec 18, 2025
DataFlex-dev
added a commit
that referenced
this pull request
Dec 18, 2025
* Update LICENSE * Fix wrong error code (#3) * Audience is now Array based (#5) * Fix wrong error code * Rewriten audience so that it is based on Array. * Merge comments Made it in a way that it still returns a string. --------- Co-authored-by: DataFlex.dev <127292730+DataFlex-dev@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Audience is now array based so that it can contain multiple audiences.
There is a short coming in the library that we cannot give an array along in the standard encoding parameters. If we would do that, it would always string escape it with some extra double quotes. The work around here is not to add it as an standard parameter but as a "additional claim". This way we would dynamically set the parameter the right way and the output is correct.