Adds a deny lint for HashMap #1741
Draft
+57
−70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
preinlein
force-pushed
the
paul.reinlein/add-hashmap-deny-lint
branch
from
029f07b to
474eb24
Compare
preinlein
commented
Jan 30, 2026
| (port_with_protocol, HashMap::<(), ()>::new()) | ||
| ( | ||
| port_with_protocol, | ||
| std::collections::HashMap::<(), ()>::new(), |
Contributor
Author
There was a problem hiding this comment.
Note: This is the only use of HashMap left, it's required for ContainerCreateBody properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
HashMapHashMapwithFxHashMapMotivation
Instead of needing to do optimizations to move from HashMap to FxHashMap, this disallows HashMap with a linting rule.
Related issues
N/A
Additional Notes
Relates to #1720, @blt had mentioned that we should just move from an optimization hint to a lint for the use of
HashMap.