Fix race condition in signal_and_wait #1740
Draft
+63
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Caleb Metz <caleb.metz@datadoghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a rare race condition in signal_and_wait that loom does not catch (without adding an explicit yield point)
Motivation
Fix race condition.
Additional Notes
The first commit adds the loom tests to prove that 1. we have a race condition, and 2. loom is unable to explore the right interleaving without an explicit yield point
The second commit applied the fix
If you checkout the first commit expect the loom test
signal_and_wait_race_proof_with_yeildto failHere is my writeup (it is not done yet)https://app.datadoghq.com/notebook/13820207/shutdown-timeout-investigation