Skip to content

Conversation

@preinlein
Copy link
Contributor

@preinlein preinlein commented Jan 29, 2026

What does this PR do?

  • removed all git branch information from the various db.yaml and skills; we don't need this as git blame is sufficient
  • remove git from existing skills
  • simplify lading-optimize-hunt so that it doesn't repeat validation/review logic and offloads it to those skills instead
  • change lading-optimize-hunt to benchmark before the optimization attempt instead of doing git worktree operations
  • add new lading-optimize-submit skill which will run /lading-optimize-hunt and capture the optimization in a git branch/commit
  • moved some files around to reflect the skill changes

Motivation

Having the core optimization loop handle git operations made testing the optimization loop difficult and it complicated the process. By extracting the git operations into a new top level skill, it allows us to test /lading-optimize-hunt more easily.

It also prevents git concepts from being peppered across the skills which increases the complexity of each skill.

Related issues

N/A

Additional Notes

I do think we want to separate the "endless hunt" from "hunt". I've taken out some of the "run endlessly" comments in the existing skills. I imagine having a new top level skill which can more simply do a for loop on /lading-optimize-submit.

I am also all ears for changing the name of lading-optimize-submit to something better. Maybe lading-capture-optimization?

Validated by:

  • running /lading-optimize-hunt with these changes and verifying that it's simply finding an optimization and determining if it's good or bad (ex: Example hunt after skill changes #1734)
  • running /lading-optimize-submit and verifying that it's checking out main, doing an optimization hunt and then creating a new branch + commit
    • this ended up being trickier than expected because it's so different from main and the git checkout main part is slightly wrecking the loop -> I'm going to get this change merged first and then validate post-merge -> if any fixes are needed, I'll do the then

@preinlein preinlein changed the title Extract Git out of skills and add new skill (DO NOT REVIEW YET): Extract Git out of skills and add new skill Jan 29, 2026
Copy link
Contributor Author

preinlein commented Jan 29, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@preinlein preinlein changed the title (DO NOT REVIEW YET): Extract Git out of skills and add new skill Extract Git out of skills and add new skill Jan 30, 2026
@preinlein preinlein marked this pull request as ready for review January 30, 2026 14:45
@preinlein preinlein requested a review from a team as a code owner January 30, 2026 14:45
@blt
Copy link
Collaborator

blt commented Jan 30, 2026

I do think we want to separate the "endless hunt" from "hunt". I've taken out some of the "run endlessly" comments in the existing skills. I imagine having a new top level skill which can more simply do a for loop on /lading-optimize-submit.

A ralph wiggum loop?

@blt
Copy link
Collaborator

blt commented Jan 30, 2026

I am also all ears for changing the name of lading-optimize-submit to something better. Maybe lading-capture-optimization?

I like -submit. -capture implies what is being done but -submit speaks more directly to my ear about pushing the change to remote.

@preinlein
Copy link
Contributor Author

I do think we want to separate the "endless hunt" from "hunt". I've taken out some of the "run endlessly" comments in the existing skills. I imagine having a new top level skill which can more simply do a for loop on /lading-optimize-submit.

A ralph wiggum loop?

Yup, that would be perfect for this. I'll see what I can do with it.

@preinlein preinlein merged commit ac835ad into main Jan 30, 2026
30 of 31 checks passed
@preinlein preinlein deleted the paul.reinlein/extract-git-out-of-skills branch January 30, 2026 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants