Extract Git out of skills and add new skill #1733
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

What does this PR do?
lading-optimize-huntso that it doesn't repeat validation/review logic and offloads it to those skills insteadlading-optimize-huntto benchmark before the optimization attempt instead of doing git worktree operationslading-optimize-submitskill which will run/lading-optimize-huntand capture the optimization in a git branch/commitMotivation
Having the core optimization loop handle git operations made testing the optimization loop difficult and it complicated the process. By extracting the git operations into a new top level skill, it allows us to test
/lading-optimize-huntmore easily.It also prevents git concepts from being peppered across the skills which increases the complexity of each skill.
Related issues
N/A
Additional Notes
I do think we want to separate the "endless hunt" from "hunt". I've taken out some of the "run endlessly" comments in the existing skills. I imagine having a new top level skill which can more simply do a for loop on
/lading-optimize-submit.I am also all ears for changing the name of
lading-optimize-submitto something better. Maybelading-capture-optimization?Validated by:
/lading-optimize-huntwith these changes and verifying that it's simply finding an optimization and determining if it's good or bad (ex: Example hunt after skill changes #1734)/lading-optimize-submitand verifying that it's checking out main, doing an optimization hunt and then creating a new branch + commit