Skip to content

Draft: mooore histograms #1731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Arpafaucon wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Draft: mooore histograms #1731

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lading/src/generator/http.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ use std::{

use hyper::{HeaderMap, Request, Uri, header::CONTENT_LENGTH};
use hyper_util::{client::legacy::Client, rt::TokioExecutor};
use metrics::counter;
use metrics::{counter, histogram};
use once_cell::sync::OnceCell;
use rand::{SeedableRng, prelude::StdRng};
use serde::{Deserialize, Serialize};
Expand Down Expand Up @@ -258,6 +258,7 @@ impl Http {
match client.request(request).await {
Ok(response) => {
counter!("bytes_written", &labels).increment(block_length as u64);
histogram!("bytes_written_histogram", &labels).record(block_length as f64);

if let Some(dp) = data_points {
counter!("data_points_transmitted", &labels).increment(dp);
Expand Down
2 changes: 1 addition & 1 deletion lading_capture/src/formats/multi.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ pub enum Error {

/// Multi-format writer
///
/// Writes metrics to both JSONL and Parquet formats, uses fail-fast sematics on
/// Writes metrics to both JSONL and Parquet formats, uses fail-fast semantics on
/// errors from either format.
#[derive(Debug)]
pub struct Format<W1: Write, W2: Write + Seek + Send> {
Expand Down
Loading