[DO NOT MERGE] Remove Mono.Unix dependency
#222
Conversation
lucaspimentel
changed the title
Mono.Unix dependency
lucaspimentel
force-pushed
the
lpimentel/remove-mono-unix
branch
2 times, most recently
from
ab0204a to
da222f4
Compare
lucaspimentel
force-pushed
the
lpimentel/remove-mono-unix
branch
from
da222f4 to
2892d63
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| public ulong st_dev; // Device | ||
| public ulong st_ino; // File serial number (inode) | ||
| public uint st_mode; // File mode | ||
| public uint st_nlink; // Link count | ||
| public uint st_uid; // User ID of the file's owner |
There was a problem hiding this comment.
On 64‑bit Linux (e.g., ubuntu-latest runners) the native struct stat layout uses 64‑bit st_nlink/st_blksize with a total size of 144 bytes (/usr/include/x86_64-linux-gnu/bits/struct_stat.h), but StatStructLinux declares those fields as 32‑bit and omits the trailing padding, making the managed struct only 128 bytes. The P/Invoke call to stat() therefore writes past the allocated buffer, which can corrupt the stack or return garbage whenever TryStat runs (OriginDetection calls it during startup). The struct definition needs to match the platform layout (e.g., 64‑bit fields or use stat64) to avoid undefined behavior.
Useful? React with 👍 / 👎.
lucaspimentel
changed the title
Mono.Unix dependencyMono.Unix dependency
|
Closing in favor of #223 |
Summary
This PR removes the
Mono.Unixpackage dependency that was added in #211. This removes the only external dependency. Furthermore,Mono.Unixnuget package versions are all considered pre-releases (semver), which blocks many users from usingdogstatsd-csharp-client.Changes
Mono.UnixdependencyNativeMethods.cswith direct P/Invoke tolibcstat()functionIFileSystem.TryStat()to use the new implementation instead ofMono.Unix.Native.Syscall.stat()UnixEndPoint.csfor UDS support (originally from Mono.Unix, was removed in [AGTMETRICS-347]Add cgroup origin detection #211)latestto enable modern syntax like file-scoped namespaces and nullable reference typesTesting
No user-facing behavior changes aside from removing the
Mono.Unixdependency.