Always run bazel:test:windows-amd64 in CI

[rdesgroppes]

Motivation

This job is critical to ensure any change, whether strictly bazel-related or in the source code being built/tested, doesn't break Windows builds.

It's the second time a breaking change is not gated properly (this time leading to #48207), so we're kindly asking to lift the Windows pipeline exclusion and always run this job in CI.

[agent-platform-auto-pr]

Gitlab CI Configuration Changes

Modified Jobs

bazel:test:windows-amd64

  bazel:test:windows-amd64:
    before_script:
    - C:\ci-identities-gitlab-job-client.exe assume-role
    id_tokens:
      CI_IDENTITIES_GITLAB_ID_TOKEN:
        aud: ci-identities
    needs: []
    rules:
-   - if: $SKIP_WINDOWS == "true"
-     when: never
    - when: on_success
    script:
    - '$FailFast = @''
  
      $ErrorActionPreference = ''Stop''
  
      $PSNativeCommandUseErrorActionPreference = $true
  
      Set-StrictMode -Version 3.0
  
      ''@
  
      Invoke-Expression $FailFast
  
      $Utf8Script = [Text.Encoding]::UTF8.GetString([Text.Encoding]::GetEncoding([Console]::OutputEncoding.CodePage).GetBytes($POWERSHELL_SCRIPT))
  
      $EncodedCommand = [Convert]::ToBase64String([Text.Encoding]::Unicode.GetBytes("$FailFast`n$Utf8Script"))'
    - .\tools\ci\docker-run-with-bazel-cache.ps1 --env=CI_IDENTITIES_GITLAB_ID_TOKEN
      --volume="${CI_PROJECT_DIR}:$CI_PROJECT_DIR" --workdir="$CI_PROJECT_DIR" "$WINBUILDIMAGE"
      powershell -NonInteractive -NoLogo -NoProfile -InputFormat Text -OutputFormat
      Text -EncodedCommand $EncodedCommand
    stage: source_test
    tags:
    - windows-v2:2022
    timeout: 60m
    variables:
      ARCH: x64
      AWS_SHARED_CREDENTIALS_FILE: ${CI_PROJECT_DIR}\.aws\credentials-by-job-id\${CI_JOB_ID}
      BAZELISK_HOME: $XDG_CACHE_HOME/bazelisk
      GIT_DEPTH: 2
      OVERRIDE_GIT_STRATEGY: clone
      POWERSHELL_SCRIPT: bazel test //bazel/tests/... //rtloader/...
      WINBUILDIMAGE: registry.ddbuild.io/ci/datadog-agent-buildimages/windows_ltsc2022_${ARCH}${CI_IMAGE_WIN_LTSC2022_X64_SUFFIX}:${CI_IMAGE_WIN_LTSC2022_X64}
      XDG_CACHE_HOME: c:/bzl

Changes Summary

Removed	Modified	Added	Renamed
0	1	0	0

ℹ️ Diff available in the job log.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d5f6c4e011

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[agent-platform-auto-pr]

Files inventory check summary

File checks results against ancestor d7a7373b:

Results for datadog-agent_7.79.0~devel.git.57.eace1e9.pipeline.103975924-1_amd64.deb:

No change detected

[cit-pr-commenter-54b7da]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: d810e539-cb13-4228-8057-b218ffc4468e

Baseline: 8ff68ee
Comparison: 281dbad
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	docker_containers_cpu	% cpu utilization	-2.47	[-5.48, +0.53]	1	Logs

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	file_tree	memory utilization	+0.30	[+0.25, +0.36]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	+0.18	[+0.15, +0.22]	1	Logs bounds checks dashboard
➖	quality_gate_idle	memory utilization	+0.17	[+0.12, +0.22]	1	Logs bounds checks dashboard
➖	otlp_ingest_metrics	memory utilization	+0.17	[+0.01, +0.33]	1	Logs
➖	uds_dogstatsd_20mb_12k_contexts_20_senders	memory utilization	+0.16	[+0.10, +0.22]	1	Logs
➖	quality_gate_metrics_logs	memory utilization	+0.16	[-0.07, +0.39]	1	Logs bounds checks dashboard
➖	ddot_logs	memory utilization	+0.12	[+0.06, +0.19]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	+0.03	[-0.40, +0.46]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	+0.01	[-0.18, +0.21]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	+0.01	[-0.51, +0.52]	1	Logs
➖	quality_gate_logs	% cpu utilization	+0.01	[-1.54, +1.55]	1	Logs bounds checks dashboard
➖	uds_dogstatsd_to_api_v3	ingress throughput	+0.00	[-0.19, +0.20]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.11, +0.11]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	-0.01	[-0.40, +0.39]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	-0.01	[-0.08, +0.06]	1	Logs
➖	ddot_metrics_sum_delta	memory utilization	-0.04	[-0.20, +0.13]	1	Logs
➖	ddot_metrics_sum_cumulative	memory utilization	-0.06	[-0.20, +0.09]	1	Logs
➖	docker_containers_memory	memory utilization	-0.16	[-0.23, -0.09]	1	Logs
➖	ddot_metrics_sum_cumulativetodelta_exporter	memory utilization	-0.17	[-0.39, +0.06]	1	Logs
➖	otlp_ingest_logs	memory utilization	-0.21	[-0.30, -0.12]	1	Logs
➖	ddot_metrics	memory utilization	-0.32	[-0.50, -0.14]	1	Logs
➖	docker_containers_cpu	% cpu utilization	-2.47	[-5.48, +0.53]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	-2.61	[-2.76, -2.45]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	observed_value	links
✅	docker_containers_cpu	simple_check_run	10/10	706 ≥ 26
✅	docker_containers_memory	memory_usage	10/10	275.34MiB ≤ 370MiB
✅	docker_containers_memory	simple_check_run	10/10	721 ≥ 26
✅	file_to_blackhole_0ms_latency	memory_usage	10/10	0.19GiB ≤ 1.20GiB
✅	file_to_blackhole_0ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10	0.23GiB ≤ 1.20GiB
✅	file_to_blackhole_1000ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_100ms_latency	memory_usage	10/10	0.19GiB ≤ 1.20GiB
✅	file_to_blackhole_100ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_500ms_latency	memory_usage	10/10	0.21GiB ≤ 1.20GiB
✅	file_to_blackhole_500ms_latency	missed_bytes	10/10	0B = 0B
✅	quality_gate_idle	intake_connections	10/10	3 = 3	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	174.84MiB ≤ 175MiB	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	2 ≤ 3	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	491.29MiB ≤ 550MiB	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	4 ≤ 6	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	203.72MiB ≤ 220MiB	bounds checks dashboard
✅	quality_gate_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard
✅	quality_gate_metrics_logs	cpu_usage	10/10	366.22 ≤ 2000	bounds checks dashboard
✅	quality_gate_metrics_logs	intake_connections	10/10	3 ≤ 6	bounds checks dashboard
✅	quality_gate_metrics_logs	memory_usage	10/10	433.03MiB ≤ 475MiB	bounds checks dashboard
✅	quality_gate_metrics_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

• quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.