Skip to content

Bump rules_foreign_cc for Bazel 9 fixes #48071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gh-worker-dd-mergequeue-cf854d merged 2 commits into from
Mar 21, 2026
Merged

Bump rules_foreign_cc for Bazel 9 fixes #48071

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7df49ec
Bump `rules_foreign_cc` for Bazel 9 fixes
rdesgroppes Mar 19, 2026
5764d7f
Address review comment
rdesgroppes Mar 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions MODULE.bazel.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion compliance/package_licenses.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ def package_licenses(name = None, src = None):
# Windows build; offers_dir is therefore always empty there. rules_python 1.9.0 makes `bazel run` copy
# runfiles to a fresh temp dir and skips empty dirs, causing pkg_install to fail with FileNotFoundError
# (Linux/macOS use symlinks so empty TreeArtifacts are fine); remove this select when Windows does.
"@platforms//os:windows": [], #TODO(agent-build): remove `select` when Windows deps use ship_source_offer
"@platforms//os:windows": [], #TODO(ABLD-351): deal with products that don't have source offers
"//conditions:default": [":%s_offer_dir_stripped_" % name],
}),
visibility = ["//visibility:public"],
Expand Down
10 changes: 6 additions & 4 deletions deps/repos.MODULE.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,18 +73,20 @@ http_archive(
)

# Defines a "rules_foreign_cc" target to build openssl
# Pinned to main commit e4068330a799ba6090d8247cf34d470f722b32c4 to get:
# Pinned to main commit 2373ac51627f05029b0068884c93fa82a11df400 to get:
# - bazel-contrib/rules_foreign_cc#1451: out_data_dirs in output groups
# - bazel-contrib/rules_foreign_cc#1465: resource_set integration (fixes overcommitting)
# - bazel-contrib/rules_foreign_cc#1470: -isystem forwarding to configure scripts
# Patch 0002 is still carried locally (bazel-contrib/rules_foreign_cc#1452 not yet merged).
# - bazel-contrib/rules_foreign_cc#1493: load CcSharedLibraryInfo from rules_cc (Bazel 9)
# - bazel-contrib/rules_foreign_cc#1492: bump bazel_skylib_gazelle_plugin to 1.9.0 (Bazel 9)
bazel_dep(name = "rules_foreign_cc", version = "0.15.1")
git_override(
module_name = "rules_foreign_cc",
commit = "e4068330a799ba6090d8247cf34d470f722b32c4",
commit = "2373ac51627f05029b0068884c93fa82a11df400",
patch_strip = 1,
patches = [
# https://github.com/bazel-contrib/rules_foreign_cc/pull/1452
"//bazel/patches:rules_foreign_cc/0002-configure_make-provide-DY-LD_LIBRARY_PATH-based-on-t.patch",
# https://github.com/bazel-contrib/rules_foreign_cc/pull/1491
"//bazel/patches:rules_foreign_cc/0003-pass-j-flag-directly-on-make-command-line.patch",
],
remote = "https://github.com/bazel-contrib/rules_foreign_cc",
Expand Down
Loading