Skip to content

[CONTINT-4918] Limit K8s event bundle messages by an estimated length#44113

Merged
dd-mergequeue[bot] merged 10 commits intomainfrom
triviajon/CONTINT-4918/k8s-event-bundle-bug
Jan 8, 2026
Merged

[CONTINT-4918] Limit K8s event bundle messages by an estimated length#44113
dd-mergequeue[bot] merged 10 commits intomainfrom
triviajon/CONTINT-4918/k8s-event-bundle-bug

Conversation

@triviajon
Copy link
Copy Markdown
Contributor

What does this PR do?

This PR addresses a bug where the the message body of events are being truncated. Example here.

The way this is solved is by allowing an object to map to a list of bundles and estimating the size of the the message body as we add events to it. Once it reaches a threshold (conservatively set to 3750, as the limit on dogweb is 4000 characters), we create a new bundle.

Motivation

https://datadoghq.atlassian.net/browse/CONTINT-4918

Describe how you validated your changes

Added unit tests TestKubernetesEventBundle_fitsEvent to pkg/collector/corechecks/cluster/kubernetesapiserver/kubernetes_eventbundle_test.go.

Additional Notes

@triviajon triviajon added qa/done QA done before merge and regressions are covered by tests and removed qa/skip-qa labels Dec 11, 2025
@agent-platform-auto-pr
Copy link
Copy Markdown
Contributor

agent-platform-auto-pr bot commented Dec 11, 2025

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor a952ae5
📊 Static Quality Gates Dashboard

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
agent_deb_amd64 $${+0}$$ $${708.12}$$ < $${708.41}$$ $${-0.05}$$ $${173.9}$$ < $${174.49}$$
agent_deb_amd64_fips $${+0}$$ $${703.42}$$ < $${704.0}$$ $${-0.01}$$ $${172.69}$$ < $${173.75}$$
agent_heroku_amd64 $${0}$$ $${328.72}$$ < $${329.53}$$ $${-0.01}$$ $${87.43}$$ < $${88.45}$$
agent_msi $${+0}$$ $${570.71}$$ < $${982.08}$$ $${-0.03}$$ $${142.67}$$ < $${143.02}$$
agent_rpm_amd64 $${+0}$$ $${708.11}$$ < $${708.38}$$ $${+0.05}$$ $${176.48}$$ < $${177.66}$$
agent_rpm_amd64_fips $${+0}$$ $${703.41}$$ < $${703.99}$$ $${-0.01}$$ $${175.92}$$ < $${176.6}$$
agent_rpm_arm64 $${-0}$$ $${689.63}$$ < $${693.52}$$ $${+0.02}$$ $${160.0}$$ < $${161.26}$$
agent_rpm_arm64_fips $${+0}$$ $${685.79}$$ < $${688.48}$$ $${-0.05}$$ $${159.38}$$ < $${160.55}$$
agent_suse_amd64 $${+0}$$ $${708.11}$$ < $${708.38}$$ $${+0.05}$$ $${176.48}$$ < $${177.66}$$
agent_suse_amd64_fips $${+0}$$ $${703.41}$$ < $${703.99}$$ $${-0.01}$$ $${175.92}$$ < $${176.6}$$
agent_suse_arm64 $${-0}$$ $${689.63}$$ < $${693.52}$$ $${+0.02}$$ $${160.0}$$ < $${161.26}$$
agent_suse_arm64_fips $${+0}$$ $${685.79}$$ < $${688.48}$$ $${-0.05}$$ $${159.38}$$ < $${160.55}$$
docker_agent_amd64 $${+0}$$ $${769.95}$$ < $${770.72}$$ $${+0}$$ $${261.75}$$ < $${262.45}$$
docker_agent_arm64 $${-0}$$ $${776.07}$$ < $${780.2}$$ $${+0}$$ $${250.81}$$ < $${252.63}$$
docker_agent_jmx_amd64 $${+0}$$ $${960.83}$$ < $${961.6}$$ $${+0.01}$$ $${330.39}$$ < $${331.08}$$
docker_agent_jmx_arm64 $${-0}$$ $${955.66}$$ < $${959.8}$$ $${+0}$$ $${315.44}$$ < $${317.27}$$
docker_cluster_agent_amd64 $${+0}$$ $${180.71}$$ < $${181.08}$$ $${+0}$$ $${63.85}$$ < $${64.49}$$
docker_cluster_agent_arm64 $${-0}$$ $${196.55}$$ < $${198.49}$$ $${-0.02}$$ $${60.12}$$ < $${61.17}$$
docker_cws_instrumentation_amd64 $${+0}$$ $${7.13}$$ < $${7.18}$$ $${+0}$$ $${2.99}$$ < $${3.33}$$
docker_cws_instrumentation_arm64 $${0}$$ $${6.69}$$ < $${6.92}$$ $${+0}$$ $${2.73}$$ < $${3.09}$$
docker_dogstatsd_amd64 $${+0}$$ $${38.78}$$ < $${39.38}$$ $${+0}$$ $${15.01}$$ < $${15.82}$$
docker_dogstatsd_arm64 $${-0}$$ $${37.07}$$ < $${37.94}$$ $${-0}$$ $${14.34}$$ < $${14.83}$$
dogstatsd_deb_amd64 $${0}$$ $${30.0}$$ < $${30.61}$$ $${-0}$$ $${7.94}$$ < $${8.79}$$
dogstatsd_deb_arm64 $${0}$$ $${28.15}$$ < $${29.11}$$ $${-0}$$ $${6.81}$$ < $${7.71}$$
dogstatsd_rpm_amd64 $${0}$$ $${30.0}$$ < $${30.61}$$ $${-0}$$ $${7.95}$$ < $${8.8}$$
dogstatsd_suse_amd64 $${0}$$ $${30.0}$$ < $${30.61}$$ $${-0}$$ $${7.95}$$ < $${8.8}$$
iot_agent_deb_amd64 $${0}$$ $${42.99}$$ < $${43.29}$$ $${-0}$$ $${11.26}$$ < $${12.04}$$
iot_agent_deb_arm64 $${0}$$ $${40.11}$$ < $${40.92}$$ $${-0}$$ $${9.63}$$ < $${10.45}$$
iot_agent_deb_armhf $${0}$$ $${40.69}$$ < $${41.03}$$ $${-0}$$ $${9.82}$$ < $${10.62}$$
iot_agent_rpm_amd64 $${0}$$ $${42.99}$$ < $${43.29}$$ $${-0}$$ $${11.28}$$ < $${12.06}$$
iot_agent_suse_amd64 $${0}$$ $${42.99}$$ < $${43.29}$$ $${-0}$$ $${11.28}$$ < $${12.06}$$

@cit-pr-commenter
Copy link
Copy Markdown

cit-pr-commenter bot commented Dec 11, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 9a68b46e-18b2-49b0-b93a-ba0a42242239

Baseline: a952ae5
Comparison: d6d6757
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +0.59 [-2.35, +3.52] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_logs % cpu utilization +3.01 [+1.53, +4.48] 1 Logs bounds checks dashboard
docker_containers_cpu % cpu utilization +0.59 [-2.35, +3.52] 1 Logs
ddot_metrics_sum_cumulative memory utilization +0.33 [+0.18, +0.49] 1 Logs
ddot_metrics_sum_delta memory utilization +0.32 [+0.12, +0.53] 1 Logs
otlp_ingest_logs memory utilization +0.30 [+0.20, +0.40] 1 Logs
ddot_metrics_sum_cumulativetodelta_exporter memory utilization +0.27 [+0.03, +0.50] 1 Logs
quality_gate_idle memory utilization +0.24 [+0.19, +0.29] 1 Logs bounds checks dashboard
ddot_logs memory utilization +0.16 [+0.09, +0.23] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.12 [-0.26, +0.50] 1 Logs
tcp_syslog_to_blackhole ingress throughput +0.10 [+0.03, +0.17] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.09 [-0.32, +0.50] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.03 [-0.47, +0.52] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.02 [-0.03, +0.06] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization +0.02 [-0.04, +0.08] 1 Logs
uds_dogstatsd_to_api_v3 ingress throughput +0.01 [-0.12, +0.14] 1 Logs
quality_gate_idle_all_features memory utilization +0.01 [-0.03, +0.05] 1 Logs bounds checks dashboard
uds_dogstatsd_to_api ingress throughput +0.01 [-0.13, +0.14] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.08, +0.08] 1 Logs
quality_gate_metrics_logs memory utilization +0.00 [-0.21, +0.22] 1 Logs bounds checks dashboard
otlp_ingest_metrics memory utilization -0.07 [-0.23, +0.08] 1 Logs
file_tree memory utilization -0.24 [-0.29, -0.19] 1 Logs
ddot_metrics memory utilization -0.36 [-0.58, -0.13] 1 Logs
docker_containers_memory memory utilization -1.66 [-1.81, -1.52] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
docker_containers_cpu simple_check_run 10/10
docker_containers_memory memory_usage 10/10
docker_containers_memory simple_check_run 10/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency lost_bytes 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_logs memory_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@triviajon triviajon marked this pull request as ready for review December 11, 2025 21:20
@triviajon triviajon requested review from a team as code owners December 11, 2025 21:21
@L3n41c
Copy link
Copy Markdown
Member

L3n41c commented Jan 7, 2026

@codex review

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 49d2770d92

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@triviajon
Copy link
Copy Markdown
Contributor Author

/merge

@dd-devflow-routing-codex
Copy link
Copy Markdown

dd-devflow-routing-codex bot commented Jan 8, 2026

View all feedbacks in Devflow UI.

2026-01-08 16:26:24 UTC ℹ️ Start processing command /merge


2026-01-08 16:27:07 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 1h (p90).


2026-01-08 17:29:20 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 2a66202 into main Jan 8, 2026
320 of 321 checks passed
@dd-mergequeue dd-mergequeue bot deleted the triviajon/CONTINT-4918/k8s-event-bundle-bug branch January 8, 2026 17:29
@github-actions github-actions bot added this to the 7.76.0 milestone Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

medium review PR review might take time qa/done QA done before merge and regressions are covered by tests team/container-integrations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants