Draft
Conversation
carlosroman
added
do-not-merge/WIP
changelog/no-changelog
github-actions
bot
added
team/agent-metric-pipelines
medium review
Contributor
Go Package Import DifferencesBaseline: a5bab4d
|
Contributor
Static quality checks✅ Please find below the results from static quality gates Successful checksInfo
8 successful checks with minimal change (< 2 KiB)
On-wire sizes (compressed)
|
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: a5bab4d Optimization Goals: ❌ Regression(s) detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | -3.27 | [-6.31, -0.24] | 1 | Logs |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ❌ | quality_gate_metrics_logs | memory utilization | +5.35 | [+5.09, +5.60] | 1 | Logs bounds checks dashboard |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +0.84 | [+0.74, +0.93] | 1 | Logs |
| ➖ | ddot_logs | memory utilization | +0.41 | [+0.34, +0.49] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulative | memory utilization | +0.30 | [+0.16, +0.44] | 1 | Logs |
| ➖ | uds_dogstatsd_20mb_12k_contexts_20_senders | memory utilization | +0.18 | [+0.11, +0.25] | 1 | Logs |
| ➖ | otlp_ingest_metrics | memory utilization | +0.15 | [-0.01, +0.30] | 1 | Logs |
| ➖ | ddot_metrics_sum_delta | memory utilization | +0.10 | [-0.07, +0.27] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | +0.10 | [+0.02, +0.18] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | +0.09 | [+0.06, +0.13] | 1 | Logs bounds checks dashboard |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | +0.07 | [-0.37, +0.51] | 1 | Logs |
| ➖ | docker_containers_memory | memory utilization | +0.07 | [-0.00, +0.14] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulativetodelta_exporter | memory utilization | +0.03 | [-0.19, +0.26] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | +0.01 | [-0.46, +0.49] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.01 | [-0.19, +0.20] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.09, +0.10] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | +0.00 | [-0.38, +0.39] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_v3 | ingress throughput | -0.01 | [-0.20, +0.19] | 1 | Logs |
| ➖ | ddot_metrics | memory utilization | -0.03 | [-0.21, +0.14] | 1 | Logs |
| ➖ | file_tree | memory utilization | -0.51 | [-0.57, -0.45] | 1 | Logs |
| ➖ | otlp_ingest_logs | memory utilization | -0.57 | [-0.67, -0.47] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | -0.62 | [-0.66, -0.57] | 1 | Logs bounds checks dashboard |
| ➖ | quality_gate_logs | % cpu utilization | -0.75 | [-2.31, +0.81] | 1 | Logs bounds checks dashboard |
| ➖ | docker_containers_cpu | % cpu utilization | -3.27 | [-6.31, -0.24] | 1 | Logs |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | observed_value | links |
|---|---|---|---|---|---|
| ✅ | docker_containers_cpu | simple_check_run | 10/10 | 744 ≥ 26 | |
| ✅ | docker_containers_memory | memory_usage | 10/10 | 274.88MiB ≤ 370MiB | |
| ✅ | docker_containers_memory | simple_check_run | 10/10 | 706 ≥ 26 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | 0.19GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_0ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | 0.23GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_1000ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | 0.19GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_100ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | 0.21GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_500ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | quality_gate_idle | intake_connections | 10/10 | 3 = 3 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | 173.12MiB ≤ 175MiB | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | 3 = 3 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | 490.61MiB ≤ 550MiB | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | 3 ≤ 6 | bounds checks dashboard |
| ✅ | quality_gate_logs | memory_usage | 10/10 | 202.69MiB ≤ 220MiB | bounds checks dashboard |
| ✅ | quality_gate_logs | missed_bytes | 10/10 | 0B = 0B | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | cpu_usage | 10/10 | 495.10 ≤ 2000 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | intake_connections | 10/10 | 3 ≤ 6 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | memory_usage | 10/10 | 431.11MiB ≤ 475MiB | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | missed_bytes | 10/10 | 0B = 0B | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
carlosroman
force-pushed
the
carlosroman/AGTMETRICS-340-v3-test-better-dogstatsd_metrics_stats
branch
2 times, most recently
from
bb97025 to
da0f2c4
Compare
carlosroman
force-pushed
the
carlosroman/AGTMETRICS-340-v3-test-better-dogstatsd_metrics_stats
branch
3 times, most recently
from
0c2a0b8 to
156f18f
Compare
carlosroman
force-pushed
the
carlosroman/AGTMETRICS-340-v3-test-better-dogstatsd_metrics_stats
branch
3 times, most recently
from
929683c to
549241a
Compare
github-actions
bot
added
long review
carlosroman
force-pushed
the
carlosroman/AGTMETRICS-340-v3-test-better-dogstatsd_metrics_stats
branch
5 times, most recently
from
96363c7 to
d90d620
Compare
carlosroman
force-pushed
the
carlosroman/AGTMETRICS-340-v3-test-better-dogstatsd_metrics_stats
branch
from
d90d620 to
108501b
Compare
Contributor
Author
|
@codex review |
|
To use Codex here, create a Codex account and connect to github. |
carlosroman
force-pushed
the
carlosroman/AGTMETRICS-340-v3-test-better-dogstatsd_metrics_stats
branch
from
108501b to
9e9c648
Compare
carlosroman
force-pushed
the
carlosroman/AGTMETRICS-340-v3-test-better-dogstatsd_metrics_stats
branch
2 times, most recently
from
1bf2f19 to
0f8ca1c
Compare
carlosroman
force-pushed
the
carlosroman/AGTMETRICS-340-v3-test-better-dogstatsd_metrics_stats
branch
from
0f8ca1c to
1115243
Compare
carlosroman
force-pushed
the
carlosroman/AGTMETRICS-340-v3-test-better-dogstatsd_metrics_stats
branch
from
1115243 to
968ff24
Compare
Contributor
Files inventory check summaryFile checks results against ancestor a5bab4d3: Results for datadog-agent_7.78.0~devel.git.653.968ff24.pipeline.103019901-1_amd64.deb:No change detected |
Contributor
Author
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 968ff2458e
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Comment on lines
+107
to
+109
| numShards := uint64(cfg.GetInt("dogstatsd_metrics_stats_num_shards")) | ||
| if numShards < 1 { | ||
| numShards = defaultNumShards |
There was a problem hiding this comment.
dogstatsd_metrics_stats_num_shards is cast to uint64 before it is validated, so a negative value from YAML/env (for example -1) becomes a huge unsigned integer, bypasses the < 1 fallback, and can trigger a massive allocation/panic when creating the shard slice at startup. Clamp or validate the signed value before converting it to uint64.
Useful? React with 👍 / 👎.
Comment on lines
+111
to
+113
| maxItems := cfg.GetInt("dogstatsd_metrics_stats_max_items") | ||
| if maxItems < 0 { | ||
| maxItems = defaultMaxItems |
There was a problem hiding this comment.
The config guard only handles negative values, so dogstatsd_metrics_stats_max_items: 0 is accepted. In that case every new metric takes the replacement branch and immediately dereferences shard.minHeap[0] while the heap is empty, causing a runtime panic on the first metric sample. Treat 0 as invalid (or default it) before using it.
Useful? React with 👍 / 👎.
Comment on lines
+278
to
+280
| //if d.dogstatsdDebugLogger != nil { | ||
| // logMessage := "Metric Name: %v | Tags: {%v} | Count: %v | Last Seen: %v " | ||
| // d.dogstatsdDebugLogger.Infof(logMessage, ms.Name, ms.Tags, ms.Count, ms.LastSeen) |
There was a problem hiding this comment.
This implementation still initializes dogstatsdDebugLogger, but the actual Infof call is commented out, so enabling DogStatsD metric stats no longer emits the per-metric debug logs that the previous implementation produced. Users who enable this feature for troubleshooting will silently lose that log signal unless logging is restored or the related setting/docs are updated.
Useful? React with 👍 / 👎.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Motivation
Describe how you validated your changes
Additional Notes