Skip to content

Disable perfsprint linter on test files#43653

Open
L3n41c wants to merge 1 commit intomainfrom
lenaic/perfsprint_2
Open

Disable perfsprint linter on test files#43653
L3n41c wants to merge 1 commit intomainfrom
lenaic/perfsprint_2

Conversation

@L3n41c
Copy link
Copy Markdown
Member

@L3n41c L3n41c commented Dec 1, 2025

What does this PR do?

Disable perfsprint linter on test files.

Motivation

Some rules were considered too strict for files where the performance isn’t critical: #43413 (comment)

Describe how you validated your changes

Additional Notes

@L3n41c L3n41c added this to the 7.75.0 milestone Dec 1, 2025
@L3n41c L3n41c requested a review from a team as a code owner December 1, 2025 06:49
@L3n41c L3n41c added [deprecated] team/containers changelog/no-changelog No changelog entry needed qa/done QA done before merge and regressions are covered by tests labels Dec 1, 2025
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Dec 1, 2025
@cit-pr-commenter
Copy link
Copy Markdown

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: a50266e5-dd9c-49a6-b733-1d5110d5b211

Baseline: fcb5852
Comparison: d80857c
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +0.84 [-2.08, +3.76] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +0.84 [-2.08, +3.76] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization +0.34 [+0.29, +0.39] 1 Logs
quality_gate_idle_all_features memory utilization +0.19 [+0.14, +0.24] 1 Logs bounds checks dashboard
ddot_metrics memory utilization +0.13 [-0.07, +0.34] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.06 [+0.01, +0.11] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.04 [-0.34, +0.42] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.04 [-0.34, +0.41] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.08, +0.08] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.00 [-0.41, +0.42] 1 Logs
uds_dogstatsd_to_api_v3 ingress throughput +0.00 [-0.13, +0.13] 1 Logs
docker_containers_memory memory utilization -0.01 [-0.09, +0.08] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.01 [-0.14, +0.12] 1 Logs
ddot_metrics_sum_cumulativetodelta_exporter memory utilization -0.03 [-0.26, +0.21] 1 Logs
file_tree memory utilization -0.09 [-0.13, -0.04] 1 Logs
quality_gate_idle memory utilization -0.17 [-0.22, -0.11] 1 Logs bounds checks dashboard
ddot_logs memory utilization -0.19 [-0.26, -0.12] 1 Logs
otlp_ingest_logs memory utilization -0.34 [-0.43, -0.25] 1 Logs
ddot_metrics_sum_cumulative memory utilization -0.45 [-0.59, -0.31] 1 Logs
ddot_metrics_sum_delta memory utilization -0.49 [-0.69, -0.30] 1 Logs
otlp_ingest_metrics memory utilization -0.54 [-0.68, -0.39] 1 Logs
quality_gate_metrics_logs memory utilization -0.55 [-0.77, -0.34] 1 Logs bounds checks dashboard
tcp_syslog_to_blackhole ingress throughput -0.62 [-0.70, -0.55] 1 Logs
quality_gate_logs % cpu utilization -2.68 [-4.11, -1.25] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
docker_containers_cpu simple_check_run 10/10
docker_containers_memory memory_usage 10/10
docker_containers_memory simple_check_run 10/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency lost_bytes 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_logs memory_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog No changelog entry needed qa/done QA done before merge and regressions are covered by tests short review PR is simple enough to be reviewed quickly team/container-integrations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants