[NOJIRA] Migrate circle-ci to github action#1036
Conversation
The Makefile checks $(GOPATH) as a Make variable and errors out if unset. actions/setup-go@v5 doesn't always export GOPATH as an env var, so set it explicitly at the workflow level. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Parameterize GINKGO_PROCS (default 4, backward compatible) and use 2 on GitHub Actions to avoid cover.profile.N missing file errors when parallel processes get zero specs assigned. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: c4001b3 | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
| with: | ||
| policy: chaos-controller | ||
| - name: Install tools | ||
| run: make -j4 install-controller-gen install-yamlfmt install-kubebuilder install-datadog-ci |
There was a problem hiding this comment.
I don't think I want to fix this error this way: it install a tool that isn't used in the job (the unit tests and e2e test don't run golangci-lint), so this takes times for no real reasons.
I think the correct fix would be in the makefile instead
| with: | ||
| policy: chaos-controller | ||
| - name: Install tools | ||
| run: make -j6 install-controller-gen install-yamlfmt install-helm install-kubebuilder install-datadog-ci |
There was a problem hiding this comment.
| run: make -j6 install-controller-gen install-yamlfmt install-helm install-kubebuilder install-datadog-ci | |
| run: make -j6 install-controller-gen install-yamlfmt install-helm install-kubebuilder install-datadog-ci golangci-lint |
same here as https://github.com/DataDog/chaos-controller/pull/1036/changes#r2804963114
There was a problem hiding this comment.
same as above:
I don't think I want to fix this error this way: it install a tool that isn't used in the job (the unit tests and e2e test don't run golangci-lint), so this takes times for no real reasons.
I think the correct fix would be in the makefile instead

What does this PR do?
Please briefly describe your changes as well as the motivation behind them:
This repo predates github action I believe, and circle-ci isn't a widely used CI provider at datadog. Migrating to github action allows us to simplify the deploy process and consolidate it with other repositories, tooling etc...
Code Quality Checklist
Testing
unittests orend-to-endtests.unittests orend-to-endtests.x