Skip to content

[NOJIRA] Migrate circle-ci to github action#1036

Merged
edznux-dd merged 13 commits intomainfrom
edouard/github-ci-instead-of-circle-maybe
Feb 13, 2026
Merged

[NOJIRA] Migrate circle-ci to github action#1036
edznux-dd merged 13 commits intomainfrom
edouard/github-ci-instead-of-circle-maybe

Conversation

@edznux-dd
Copy link
Contributor

What does this PR do?

  • Adds new functionality
  • Alters existing functionality
  • Fixes a bug
  • Improves documentation or testing

Please briefly describe your changes as well as the motivation behind them:

This repo predates github action I believe, and circle-ci isn't a widely used CI provider at datadog. Migrating to github action allows us to simplify the deploy process and consolidate it with other repositories, tooling etc...

Code Quality Checklist

  • The documentation is up to date.
  • My code is sufficiently commented and passes continuous integration checks.
  • I have signed my commit (see Contributing Docs).

Testing

  • I leveraged continuous integration testing
    • by depending on existing unit tests or end-to-end tests.
    • by adding new unit tests or end-to-end tests.
  • I manually tested the following steps:
    • x
    • locally.
    • as a canary deployment to a cluster.

edznux-dd and others added 10 commits February 11, 2026 18:55
The Makefile checks $(GOPATH) as a Make variable and errors out if unset.
actions/setup-go@v5 doesn't always export GOPATH as an env var, so set
it explicitly at the workflow level.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Parameterize GINKGO_PROCS (default 4, backward compatible) and use 2
on GitHub Actions to avoid cover.profile.N missing file errors when
parallel processes get zero specs assigned.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@datadog-official
Copy link

datadog-official bot commented Feb 13, 2026

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 39.27%

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: c4001b3 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@edznux-dd edznux-dd marked this pull request as ready for review February 13, 2026 08:50
@edznux-dd edznux-dd requested a review from a team as a code owner February 13, 2026 08:50
@edznux-dd edznux-dd mentioned this pull request Feb 13, 2026
13 tasks
with:
policy: chaos-controller
- name: Install tools
run: make -j4 install-controller-gen install-yamlfmt install-kubebuilder install-datadog-ci
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
run: make -j4 install-controller-gen install-yamlfmt install-kubebuilder install-datadog-ci
run: make -j4 install-controller-gen install-yamlfmt install-kubebuilder install-datadog-ci install-golangci-lint

To fix the following error

Image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think I want to fix this error this way: it install a tool that isn't used in the job (the unit tests and e2e test don't run golangci-lint), so this takes times for no real reasons.

I think the correct fix would be in the makefile instead

with:
policy: chaos-controller
- name: Install tools
run: make -j6 install-controller-gen install-yamlfmt install-helm install-kubebuilder install-datadog-ci
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
run: make -j6 install-controller-gen install-yamlfmt install-helm install-kubebuilder install-datadog-ci
run: make -j6 install-controller-gen install-yamlfmt install-helm install-kubebuilder install-datadog-ci golangci-lint

same here as https://github.com/DataDog/chaos-controller/pull/1036/changes#r2804963114

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above:

I don't think I want to fix this error this way: it install a tool that isn't used in the job (the unit tests and e2e test don't run golangci-lint), so this takes times for no real reasons.
I think the correct fix would be in the makefile instead

@edznux-dd edznux-dd merged commit 372d07a into main Feb 13, 2026
30 checks passed
@edznux-dd edznux-dd deleted the edouard/github-ci-instead-of-circle-maybe branch February 13, 2026 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants