feat(phase-2.2): structural token tests #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added 7 structural token tests: - Simple sequences and mappings - Empty values - Nested structures - Spacing variations (dash and colon) - Fixed lexer dash handling: - Dash without trailing space (e.g., '-one') correctly treated as unquoted string - Dash with space (e.g., '- item') correctly recognised as list indicator - Updated scan_unquoted_string to include dash in valid characters Tests: 64 total (10 basic + 15 scalars + 17 values + 15 fixtures + 7 structural) All tests passing (100% success rate) Co-Authored-By: Warp <agent@warp.dev>
|
Review changes with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phase 2.2: Structural Token Tests
Adds comprehensive tests for YAML structural token patterns and fixes dash handling in the lexer.
Changes
7 new structural token tests:
Lexer improvements:
Test Results
Next Steps
Phase 2.3 will implement indentation tracking with INDENT/DEDENT tokens.