Skip to content

Conversation

@m-iwanicki
Copy link
Contributor

No description provided.

@m-iwanicki m-iwanicki self-assigned this Sep 15, 2025
Signed-off-by: Michał Iwanicki <michal.iwanicki@3mdeb.com>
@m-iwanicki m-iwanicki marked this pull request as ready for review September 17, 2025 14:22
@m-iwanicki m-iwanicki requested a review from DaniilKl September 17, 2025 14:22
@BeataZdunczyk BeataZdunczyk requested review from 3mkusiak and aronowski and removed request for 3mkusiak September 24, 2025 12:49
Copy link
Contributor

@aronowski aronowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a comment about one scenario I'd like to consult on.

Copy link
Contributor

@DaniilKl DaniilKl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good. The coverage is definitely not full and we should work on it. I am worried that we do not have a clear written down heuristics behind our testing. But I think it is a part of a larger issue that I need to create.

Copy link
Contributor

@DaniilKl DaniilKl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: Michał Iwanicki <michal.iwanicki@3mdeb.com>
@m-iwanicki m-iwanicki merged commit 48f4d50 into develop Sep 26, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants