Check BtG key before updating via Capsule Update #285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ey compatibility Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com>
mkopec
force-pushed
the
btg_check
branch
6 times, most recently
from
fe44a52 to
3b4672f
Compare
Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com>
…edundant debug print Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com>
miczyg1
previously requested changes
Dec 10, 2025
SergiiDmytruk
requested changes
Dec 10, 2025
Member
SergiiDmytruk
left a comment
SergiiDmytruk
left a comment
There was a problem hiding this comment.
Came back after looking at coreboot changes.
…style Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com>
…line Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com>
…STS6 bit 30 Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com>
…tG key fail message Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com>
Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com>
…OemRootKey Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com>
… Flashing.c Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com>
…if descriptor is unlocked Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com>
mkopec
force-pushed
the
btg_check
branch
10 times, most recently
from
2a9ee67 to
6b73897
Compare
… don't match FPF Show a 2x scaled popup on the screen to inform the user what's happened and what to do in this situation. Print some debug info to the screen to provide to developers. Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com>
SergiiDmytruk
requested changes
Dec 17, 2025
Member
SergiiDmytruk
left a comment
SergiiDmytruk
left a comment
There was a problem hiding this comment.
A few things to fix. Haven't tested the dialog yet, will also need to go through its implementation in more detail.
Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com>
…ee string literal Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com>
…iadic arguments with va_copy Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com>
…0s timer remnants Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com>
…ize popup scaling factor Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com>
…cale factor based on resolution Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com>
…imer event Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com>
… key is hashed Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com>
Member
Author
|
Looks like this: |
…opup to fit 800x600 Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com>
…ing calculations Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com>
SergiiDmytruk
approved these changes
Dec 18, 2025
Member
SergiiDmytruk
left a comment
SergiiDmytruk
left a comment
There was a problem hiding this comment.
LGTM, just one question to be sure we've thought about all cases here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rejects updating via Capsule Update if BtG is enabled and the updated image does not have the same OEM Root Key in the key manifest.
ref: ncm-2095