-
-
Notifications
You must be signed in to change notification settings - Fork 9
Descriptor lockdown #274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Descriptor lockdown #274
Conversation
…scriptor is locked Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com>
|
Does not work yet, it seems that reading the DescriptorWriteable EFI variable fails. |
|
Tested: Booted V540TU to the setup menu and verified that the HAP option does not appear anymore - except on first boot, where coreboot cannot set the variable due to the EFI store not being initialized. Managed to succesfuly initiate Capsule Update twice without setting the ME to HAP mode, too, however the actual update got stuck at a black screen both times and the laptop got bricked. @SergiiDmytruk do you have some ideas? |
…scriptor is locked Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com>
…iptor is locked Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com>
Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com>
…I var Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com>
…ures.c: correct logic for descriptor writeability Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com>
3f3e17e to
09b49b3
Compare
|
Assuming SMMSTORE wasn't damaged by coreboot, EDK should start executing either way (like it did before HAP check was introduced). If the screen is black, nothing should have been read from the flash yet, so probably not a hang due to flash not being readable. The behaviour may be reproducible on other hardware with logging or even in QEMU. I also don't remember there being checks in other places.
|
|
Ahh now that the ME is not in HAP mode, the code tries to enable HMRFPO, which causes a global reset and corrupts the capsule data... Need to remove the HMRFPO enabling code at least until capsule on disk is introduced |
Needs Dasharo/coreboot#760