Skip to content

Conversation

@dependabot
Copy link

@dependabot dependabot bot commented on behalf of github Nov 25, 2024

Bumps actions/upload-artifact from 2 to 4.

Release notes

Sourced from actions/upload-artifact's releases.

v4.0.0

What's Changed

The release of upload-artifact@v4 and download-artifact@v4 are major changes to the backend architecture of Artifacts. They have numerous performance and behavioral improvements.

ℹ️ However, this is a major update that includes breaking changes. Artifacts created with versions v3 and below are not compatible with the v4 actions. Uploads and downloads must use the same major actions versions. There are also key differences from previous versions that may require updates to your workflows.

For more information, please see:

  1. The changelog post.
  2. The README.
  3. The migration documentation.
  4. As well as the underlying npm package, @​actions/artifact documentation.

New Contributors

Full Changelog: actions/upload-artifact@v3...v4.0.0

v3.2.1

What's Changed

This fixes the include-hidden-files input introduced in https://github.com/actions/upload-artifact/releases/tag/v3.2.0

Full Changelog: actions/upload-artifact@v3.2.0...v3.2.1

v3.2.1-node20

What's Changed

This fixes the include-hidden-files input introduced in https://github.com/actions/upload-artifact/releases/tag/v3.2.0-node20

Full Changelog: actions/upload-artifact@v3.2.0-node20...v3.2.1-node20

v3.2.0

Notice: Breaking Changes ⚠️

We will no longer include hidden files and folders by default in the upload-artifact action of this version. This reduces the risk that credentials are accidentally uploaded into artifacts. Customers who need to continue to upload these files can use a new option, include-hidden-files, to continue to do so.

See "Notice of upcoming deprecations and breaking changes in GitHub Actions runners" changelog and this issue for more details.

What's Changed

... (truncated)

Commits
  • b4b15b8 Merge pull request #632 from actions/joshmgross/undo-dependency-changes
  • 92b01eb Undo indirect dependency updates from #627
  • 8448086 Merge pull request #627 from actions/robherley/v4.4.2
  • b1d4642 add explicit relative and absolute symlinks to workflow
  • d50e660 bump version
  • aabe6f8 build with @​actions/artifact v2.1.11
  • 604373d Merge pull request #625 from actions/robherley/artifact-2.1.10
  • 0150148 paste right core version
  • a009b25 update licenses
  • 9f6f6f4 update @​actions/core and @​actions/artifact to latest versions
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Stojek139808 and others added 30 commits June 15, 2024 15:31
…tures.c: Remove extra newline

Co-authored-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Signed-off-by: Kacper Stojek <kacper.stojek@3mdeb.com>
…ge for handoff at ReadyToBoot

Signed-off-by: Kacper Stojek <kacper.stojek@3mdeb.com>
…ar to a single uint8 value

Signed-off-by: Kacper Stojek <kacper.stojek@3mdeb.com>
…p to changes in efivar

Signed-off-by: Kacper Stojek <kacper.stojek@3mdeb.com>
…t of PcdVTdPolicyPropertyMask

Signed-off-by: Kacper Stojek <kacper.stojek@3mdeb.com>
…wrong values in IommuConfig

Signed-off-by: Kacper Stojek <kacper.stojek@3mdeb.com>
…e proper variable types

Signed-off-by: Kacper Stojek <kacper.stojek@3mdeb.com>
Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
…tures.c: disable IOMMU by default

Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
…ble option

Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com>
…option

Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
…ot enabled

Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Co-authored-by: Michał Kopeć <michal.kopec@3mdeb.com>
…s for variables

Signed-off-by: Karol Zmyslowski <karol.zmyslowski@3mdeb.com>
…turesVfr.vfr: fix default and add reset requirement

Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
…tures.c: handle interactive NetworkBoot default

Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
… WDT timeout depend on PCD

Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
…h PCD if not enabled

Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
…tures: add FUM

This commit adds option in security menu to enable Firmware Update Mode.
As a result, UEFI variable is set, which will be later caught by
coreboot and acted upon to disable firmware write protections.

Signed-off-by: Krystian Hebel <krystian.hebel@3mdeb.com>
Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Selects state the system gets into when power supply is restored after
power failure.

Adds gDasharoSystemFeaturesTokenSpaceGuid.PcdDefaultPowerFailureState
PCD which sets its default value.

Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
It controls visibility of sleep type inside Power Management Options
submenu.

The PCD is on by default for compatibility.

Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
…ants

Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
…tures.c: warn about network use

DTS will be automatically started after FUM is enabled. Inform user that
Ethernet cable must be plugged in for seamless update process.

Signed-off-by: Krystian Hebel <krystian.hebel@3mdeb.com>
…Fi + BT radios setting

Signed-off-by: Mixss <michal.ziemiec@3mdeb.com>
Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com>
philipanda and others added 26 commits July 26, 2024 10:25
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
This gives a caller a chance to report a meaningful error to the user.

Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Commit b68d566 added support for
input subject name with signtool and broke --decode operation by using
incorrect identifier in one place (could be an incomplete rename during
review).

It's `args.SignToolSubjectName`, not `args.SignSubjectName`.

Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
This field seems to be one-based according UEFI specification, default
value is 1 and --decode of GenerateCapsule.py errors upon seeing
UpdateImageIndex less than 1.  So align --encode behaviour to enforce a
value within the 1..255 range.

Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Print error text from the exception.

Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
--decode unconditionally uses args.OutputFile.name as a prefix for
output files that it creates and fails in a non-pretty way without
--output option.

This doesn't address creation/truncation of the file specified via
--output, but at least you're able to decode a capsule.

Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Just add a space between colon and a more detailed error message in two
places.

Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
struct.unpack() returns a tuple even for a single-element pack,
resulting in signature verification being evaluated to false even when
the signature is there.

This fixes --decode and --dump-info actions incorrectly reporting issues
with parsing capsule dependencies when there are none.

Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
…he INF file

Fix build complaining on missing ParseVBootWorkbuf.

Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Add PlatformGopPolicy to use external GOP driver

Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
Use PlatformGopPolicy in place of GraphicsOutputDxe if command
line param passed

Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Make gmtime() return pointer to a statically allocated storage.  This
is how it's documented and that's how it gets used.  The API isn't
thread-safe but given that EDK2 is essentially single-threaded (MP
Services Protocol is a special exception).

Given that this code gets run at runtime phase, the leak could
potentially be used to exhaust memory reserved for the runtime phase.

Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
This is a follow up for 6ca2060
and 784750e which provide more detailed
information on the issue and how this addresses it.

The files modified by this commit were chosen based on the list of
sources in CryptoPkg/Library/BaseCryptLibMbedTls/RuntimeCryptLib.inf

The only source permitted to request memory from boot services is
SysCall/RuntimeMemAllocation.c which does it in constructor before
ExitBootServices() is called.

Trying to update minimal set of files because some of the API which does
allocations get used outside of BaseCryptLibMbedTls and can do
FreePool().  In the updated files, allocations are of two types:
 - temporary allocations within a function (they don't get returned or
   set to some output parameter)
 - paired alloc/free kind of functions which remain in control of how
   the memory is treated

Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
This is a port of upstream commits c248802 and bfefdc2

On modern platforms with TBT devices the coreboot resource allocator
opens large PCI bridge MMIO windows above 4GiB to place hotplugable
PCI BARs there as they won't fit below 4GiB. In addition modern
GPGPU devices have very big PCI bars that doesn't fit below 4GiB.

The PciHostBridgeLib made lots of assumptions about the coreboot
resource allocator that were not verified at runtime and are no
longer true.

Remove all of the 'coreboot specific' code and implement the same
logic as OvmfPkg's ScanForRootBridges.

Fixes assertion
"ASSERT [PciHostBridgeDxe] Bridge->Mem.Limit < 0x0000000100000000ULL".

Co-authored-by: Patrick Rudolph <patrick.rudolph@9elements.com>
Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com>
Tcg2PhysicalPresenceLibSubmitRequestToPreOSFunction writes to TPM2
physical presence PPI provided by coreboot (a memory region preserved
across reboots). CPU caches must be explicitly flushed prior to platform
reboot or request written to PPI will be lost.

Signed-off-by: Artur Kowalski <artur.kowalski@3mdeb.com>
Flush cache not only when placing request in PPI, but also after
clearing old request from PPI.

Signed-off-by: Artur Kowalski <artur.kowalski@3mdeb.com>
It has been observed on MinnowBoard Turbot that the detected CPU
count is lower than the number of all cores. In the tested unit, CPU is
dual core, so only the BSP is detected. However, similar situation is
observed on MTL laptop, where a total of 22 cores should be reported,
but only 1 is detected.

After EDK2 rebase a new PCD has been added, PcdFirstTimeWakeUpAPsBySipi
which, when enabled (by default), sends only SIPI to APs. When disabled
sends full INIT-SIPI-SIPI sequence. Only the latter case causes all the
APs to wake up and be detected.

Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Signed-off-by: Wiktor Mowinski <wiktor.mowinski@3mdeb.com>
This fixes "SecurityPkg: measure Dasharo variables before boot".

gRT->GetNextVariableName() doesn't return variables in any fixed order.
Seems like the order matches order in SMMSTORE.  This means that
measuring variables while enumerating them will produce different
results depending on which variables were update last (setting a
variable in SMMSTORE is marking old entry as deleted and appending of a
new one).  Sort list of variables that share the same GUID before
measuring any of them to impose a fixed order.

Also fix spacing in several places.

Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
…hout spaces

Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Match the help text string with what can actually be set at runtime.

Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 2 to 4.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@v2...v4)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels Nov 25, 2024
@dependabot @github
Copy link
Author

dependabot bot commented on behalf of github Nov 25, 2024

Dependabot tried to add @makubacki, @mdkinney and @spbrogan as reviewers to this PR, but received the following error from GitHub:

POST https://api.github.com/repos/Dasharo/edk2/pulls/191/requested_reviewers: 422 - Reviews may only be requested from collaborators. One or more of the users or teams you specified is not a collaborator of the Dasharo/edk2 repository. // See: https://docs.github.com/rest/pulls/review-requests#request-reviewers-for-a-pull-request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.