-
-
Notifications
You must be signed in to change notification settings - Fork 24
docs/variants/protectli_vp2430: add #932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0cebf4b to
dee06db
Compare
1b5dc08 to
60a918c
Compare
miczyg1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Will probably have to wait before merging, as the board will probably have to remain hidden.
|
Is it possible that we "hide" the boards by simply commenting out them in menu layout: https://github.com/Dasharo/docs/pull/932/files#diff-98d0f806abc9af24e6a7c545d3d77e8f9ad57643e27211d7a7b896113e420ed2R334 providing some reasoning? Leaving unmerged PRs means they got stale and need to be rebased over and over. WDYT @BeataZdunczyk @miczyg1 @filipleple Can we use such a process here? |
You can comment the files in the TOC. But there are also tabs in the unified documentation which you would have to comment with HTML marks AFAIK |
|
@macpijan I've commented out all of the additions as suggested. I don't understand why pre-commit complains only about the lines I've added in |
|
I think we won't make CI happy by commenting out the new pages and modifications in existing pages. I guess the best we can do is to remove the HTML comments and just wait for the platform to be officially out, then merge it |
|
@miczyg1 please have a look if it's OK to merge now |
Looks good, but I would check the test matrix again. I believe a lot has changed since November/December 2024 |
Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
…sed for v0.9.0 rc4 testing Signed-off-by: Jakub Redmerski <jakub.redmerski@3mdeb.com>
Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
|
@miczyg1 good idea, I've cross-referenced with the current RC's test matrix in osfv-dashboard and with odroid's test matrix in the docs, we should be up to date now |
No description provided.