Skip to content

Conversation

@filipleple
Copy link
Member

No description provided.

@filipleple filipleple self-assigned this Nov 7, 2024
@filipleple filipleple force-pushed the vp2430_add branch 2 times, most recently from 0cebf4b to dee06db Compare November 13, 2024 11:46
@filipleple filipleple marked this pull request as ready for review November 13, 2024 14:23
@filipleple filipleple force-pushed the vp2430_add branch 2 times, most recently from 1b5dc08 to 60a918c Compare December 9, 2024 18:35
@filipleple filipleple requested a review from miczyg1 December 9, 2024 18:42
Copy link
Contributor

@miczyg1 miczyg1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Will probably have to wait before merging, as the board will probably have to remain hidden.

@macpijan
Copy link
Contributor

Is it possible that we "hide" the boards by simply commenting out them in menu layout: https://github.com/Dasharo/docs/pull/932/files#diff-98d0f806abc9af24e6a7c545d3d77e8f9ad57643e27211d7a7b896113e420ed2R334 providing some reasoning?

Leaving unmerged PRs means they got stale and need to be rebased over and over.

WDYT @BeataZdunczyk @miczyg1 @filipleple Can we use such a process here?

@miczyg1
Copy link
Contributor

miczyg1 commented Dec 10, 2024

Is it possible that we "hide" the boards by simply commenting out them in menu layout: https://github.com/Dasharo/docs/pull/932/files#diff-98d0f806abc9af24e6a7c545d3d77e8f9ad57643e27211d7a7b896113e420ed2R334 providing some reasoning?

Leaving unmerged PRs means they got stale and need to be rebased over and over.

WDYT @BeataZdunczyk @miczyg1 @filipleple Can we use such a process here?

You can comment the files in the TOC. But there are also tabs in the unified documentation which you would have to comment with HTML marks AFAIK

@filipleple
Copy link
Member Author

filipleple commented Dec 19, 2024

@macpijan I've commented out all of the additions as suggested. I don't understand why pre-commit complains only about the lines I've added in protectli/test-matrix.md, while almost all of the lines in that file have always exceeded the 80 character limit. Also this approach means we'll pretty much always have some orphan pages detected

miczyg1
miczyg1 previously requested changes Mar 6, 2025
@JakubRed JakubRed requested a review from miczyg1 March 14, 2025 11:02
@miczyg1
Copy link
Contributor

miczyg1 commented Mar 14, 2025

I think we won't make CI happy by commenting out the new pages and modifications in existing pages. I guess the best we can do is to remove the HTML comments and just wait for the platform to be officially out, then merge it

@filipleple
Copy link
Member Author

@miczyg1 please have a look if it's OK to merge now

@miczyg1
Copy link
Contributor

miczyg1 commented May 7, 2025

@miczyg1 please have a look if it's OK to merge now

Looks good, but I would check the test matrix again. I believe a lot has changed since November/December 2024

filipleple and others added 5 commits May 7, 2025 11:26
Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
…sed for v0.9.0 rc4 testing

Signed-off-by: Jakub Redmerski <jakub.redmerski@3mdeb.com>
Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
@filipleple
Copy link
Member Author

@miczyg1 good idea, I've cross-referenced with the current RC's test matrix in osfv-dashboard and with odroid's test matrix in the docs, we should be up to date now

@mkopec mkopec dismissed miczyg1’s stale review May 8, 2025 10:28

addressed

@mkopec mkopec merged commit 14ae81a into master May 8, 2025
4 checks passed
@mkopec mkopec deleted the vp2430_add branch May 8, 2025 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants