Skip to content

NUC BOX: config changed for capsule update #726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SergiiDmytruk merged 1 commit into from
Jul 29, 2025
Merged

NUC BOX: config changed for capsule update #726

SergiiDmytruk merged 1 commit into from
Jul 29, 2025

Conversation

@matmacieje
Copy link
Contributor

@matmacieje matmacieje commented Jul 25, 2025 •
edited by SergiiDmytruk
Loading

ref: ncm-1893

@matmacieje matmacieje requested a review from SergiiDmytruk July 25, 2025 12:38
@matmacieje matmacieje changed the title Nuc box capsule0001 NUC BOX: config changed for capsule update Jul 25, 2025
SergiiDmytruk
SergiiDmytruk requested changes Jul 25, 2025
View reviewed changes
Copy link
Member

@SergiiDmytruk SergiiDmytruk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to close a PR to modify it or name branches with numbers at the end. Just do git push -f to update the branch if normal push doesn't work and you intent to discard previous state of the remote branch you're pushing.

1ad7835 shouldn't be here. It can be removed by running git rebase -i HEAD~2, removing the first line and quitting the editor while saving changes. Then do git push -f.

@matmacieje matmacieje force-pushed the nuc_box_capsule0001 branch from 8398fcf to 0ea0333 Compare July 28, 2025 15:03
@matmacieje
Copy link
Contributor Author

matmacieje commented Jul 28, 2025

Done.

@matmacieje
Copy link
Contributor Author

matmacieje commented Jul 28, 2025

Manual test of capsule update on NUC BOX:
20250728_170646
20250728_170735
20250728_170821
20250728_170823
20250728_170827
20250728_170942

@matmacieje matmacieje requested a review from SergiiDmytruk July 28, 2025 15:15
@matmacieje matmacieje linked an issue Jul 28, 2025 that may be closed by this pull request
Capsule Update integration for NUC BOX Dasharo/dasharo-issues#1457
Closed
5 tasks
SergiiDmytruk
SergiiDmytruk approved these changes Jul 28, 2025
View reviewed changes
Copy link
Member

@SergiiDmytruk SergiiDmytruk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pushed a bump of EDK revision to fix CI (a force push in EDK's PR before merging it invalidated the revision).

@matmacieje
Copy link
Contributor Author

matmacieje commented Jul 29, 2025

@SergiiDmytruk is anything missing here before merge?

@matmacieje @SergiiDmytruk
configs/config.novacustom_nuc_box: capsule update enabled.
b4f1817 
Upstream-Status: Inappropriate [Dasharo downstream]
Signed-off-by: Mateusz Maciejewski <mateusz.maciejewski@3mdeb.com>
@SergiiDmytruk
Copy link
Member

SergiiDmytruk commented Jul 29, 2025

No, I just couldn't merge right away without CI finishing first. Now target branch is outdated again, so need another CI run.

@SergiiDmytruk SergiiDmytruk merged commit b4f1817 into dasharo Jul 29, 2025
58 of 60 checks passed
@SergiiDmytruk SergiiDmytruk deleted the nuc_box_capsule0001 branch July 29, 2025 13:27
@BeataZdunczyk BeataZdunczyk mentioned this pull request Jul 31, 2025
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SergiiDmytruk SergiiDmytruk SergiiDmytruk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Capsule Update integration for NUC BOX

3 participants

@matmacieje @SergiiDmytruk