Minor revert of two changes from #780#804
Open
FalloutFalcon wants to merge 1 commit intoDarkPack13:masterfrom
Open
Minor revert of two changes from #780#804FalloutFalcon wants to merge 1 commit intoDarkPack13:masterfrom
FalloutFalcon wants to merge 1 commit intoDarkPack13:masterfrom
Conversation
Contributor
|
it'll still yap station slogans unless you null those out, we need the change. if people want snowflakey machines that cost credits, theyll need to make a credits system. if they want to have one that yaps slogans, they can override the init proc the commented out wod13 glasses can be outright removed, they dont update sprites nor name when drinks are poured in and are mostly broken as-is; i think the shot glass straight up vanishes when you pour stuff into it also i think there are higher priority items to worry about than this :( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About The Pull Request
reverts the drink and boozeomat changes made in #780 as they were never addressed and pushed through.
Why It's Good For The Game
The removal of all drink glasses expect wine_glass (which also put it outside of the modular edit) was not justified or really explained.
For the init code, we have a type that is better to use and its bad to have random setting initialize behavior like that as it overides subtype and varedit behavoir.
