Fixes oversight with retail store money handling#784
Open
FalloutFalcon wants to merge 3 commits intoDarkPack13:masterfrom
Open
Fixes oversight with retail store money handling#784FalloutFalcon wants to merge 3 commits intoDarkPack13:masterfrom
FalloutFalcon wants to merge 3 commits intoDarkPack13:masterfrom
Conversation
XeonMations
approved these changes
Mar 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About The Pull Request
My code checks iscash for the ui_data but checked for a single type in the ui_act, that combined with the fact the code couldnt handle if it didnt find a credit card or cash meant you could infinitly buy items with a single gold coin (considered cash by iscash)
I decided to just make it istype for dollars, as the code assumes
.uselines up 1 to 1 with the value and coins dont even have a use act.also added a catch for the stock being free and therefore not running money checks tho its not applied anywhere.
Why It's Good For The Game
bug bad. plus the coins (and the other things caught by iscash that arent dollars) in our code arent modern fundiable money and are at best some ancient coinage. (they are stuff like silver and gold atm) mabye we should make the pawn shop accept them at some point soon.
Changelog
🆑
fix: Fixed coins allowing for infinite expenditure at a retail store
/:cl: