Skip to content

aura rework#781

Open
buffyuwu wants to merge 12 commits intoDarkPack13:masterfrom
buffyuwu:aura-stuff
Open

aura rework#781
buffyuwu wants to merge 12 commits intoDarkPack13:masterfrom
buffyuwu:aura-stuff

Conversation

@buffyuwu
Copy link
Copy Markdown
Contributor

@buffyuwu buffyuwu commented Mar 19, 2026

About The Pull Request

auras good

Changelog

🆑
add: adds particle based auras
/:cl:

Comment on lines +93 to +95
switch(current_aura)
if(AURA_AFRAID)
examine_message = "[parent_mob.p_Their()] aura burns a bright orange, tense and flickering at the edges."
Copy link
Copy Markdown
Member

@FalloutFalcon FalloutFalcon Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like i said earlier, we should probably convey the emotion more directly.. We want to convey it at a glance in the same way a character would just know, we shouldnt really need to ask players to pop open a book or wiki for something like this

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i like where your head is at. i copied directly from the book and added a bit of flair on top. maybe, the sentence describes the appearance, then describes the emotion?

Suggested change
switch(current_aura)
if(AURA_AFRAID)
examine_message = "[parent_mob.p_Their()] aura burns a bright orange, tense and flickering at the edges."
switch(current_aura)
if(AURA_AFRAID)
examine_message = "[parent_mob.p_Their()] aura burns a bright orange, tense and flickering at the edges, showing signs of fear."

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes though it can likely pull the emotion with code. We do this with #598 and im considering atomizing out the emotion changes from that as it touches alot of aura code.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor correction. I was thinking of #622 which is already merged!

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh cool, so i can leave auras as-is then? no need to add emotion text?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well no as i didnt actually make those changes for aura but one of the discipline powers in that pr

buffyuwu and others added 4 commits March 27, 2026 10:27
…mponent.dm

Co-authored-by: FalloutFalcon <86381784+FalloutFalcon@users.noreply.github.com>
…mponent.dm

Co-authored-by: FalloutFalcon <86381784+FalloutFalcon@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants