Conversation
…o rest-of-auspice-gifts
…o rest-of-auspice-gifts
…lout-fallcon-plays
chazzyjazzy
left a comment
chazzyjazzy
left a comment
There was a problem hiding this comment.
ok unless im missing something major this should be fine. might wanna test the fianna gift tho but I assume u have. basically my review is just roll datumization
| owner.st_add_stat_mod(STAT_PERCEPTION, 1, type) | ||
| owner.st_add_stat_mod(STAT_INTELLIGENCE, 1, type) | ||
| owner.st_add_stat_mod(STAT_WITS, 1, type) |
There was a problem hiding this comment.
im assuming type is just the typepath? shouldnt sources be defines? i think i remember that being a comment on one of my prs
| var/datum/storyteller_roll/roll_datum = new() | ||
| roll_datum.difficulty = roll_difficulty | ||
| var/roll_result = roll_datum.st_roll(caster, target, casting_splat.gnosis) |
There was a problem hiding this comment.
maybe a nitpick since i think abby said new()'ing a new datum every time isnt that cost heavy, but to make things cleaner i would suggest storing the datum on the action, then checking if it exists here, and if it doesn't, new() it, so that u only ever create the new datum once, if that makes sense
| var/datum/storyteller_roll/roll_datum = new() | ||
| roll_datum.applicable_stats = list(STAT_WITS, STAT_OCCULT) | ||
| roll_datum.difficulty = 6 | ||
| var/roll_result = roll_datum.st_roll(owner) | ||
|
|
||
| if(roll_result <= 0) | ||
| return FALSE |
There was a problem hiding this comment.
is the roll numerical = true? also ditto with previous thingy
3 participants
About The Pull Request
DEPENDENCY: #692Why It's Good For The Game
werewolf gifts need to be fully featured at some point, might as well start with these.
Changelog
🆑
add: Black Furies gift: Breath of the Wyld
add: Bone Gnawers gift: Desperate Strength
add: Fianna gift: Faerie Light
add: Get of Fenris gift: Visage of Fenris
/:cl: