Skip to content

Merit pack from MOSTLY W20#709

Open
FalloutFalcon wants to merge 32 commits intoDarkPack13:masterfrom
FalloutFalcon:some-wolf-traits
Open

Merit pack from MOSTLY W20#709
FalloutFalcon wants to merge 32 commits intoDarkPack13:masterfrom
FalloutFalcon:some-wolf-traits

Conversation

@FalloutFalcon
Copy link
Copy Markdown
Member

@FalloutFalcon FalloutFalcon commented Feb 23, 2026

About The Pull Request

Assorted merits and flaws from W20. (some overlap with V20) Also grabbed pale aura cause it was really easy.

Had to fix some stuff relating to SPLAT_NONE with how quirks are handled but that's not even chaz's fault the code is just obtuse (this is my fault mostly)

Fixes #693

Why It's Good For The Game

merits for wolves (and others)

Changelog

🆑
add: Adds the merits: Time Sense, Fair Glabro, Metamorph, Untamable, Pale aura, Deceptive Aura
add: Adds the flaws: Animal Musk, One Eye, Weakwilled, Pierced Veil
balance: An accurate display of city time for living mobs is now locked behind time sense.
fix: Derangement now appear as a selectable flaw again.
typo: "Your" to "You" in a dominate to_chat
/:cl:

@FalloutFalcon FalloutFalcon changed the title Merit pack from W20 Merit pack from MOSTLY W20 Feb 24, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 4, 2026

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~7 days. Please address any outstanding review items and ensure your PR is finished - if both are true, and you have auto-staled anyway, you need to actively ask maintainers (by pinging them in the /tg/station Discord) to (re)review or merge your PR. If no maintainer responds to your request, you may wish to close this PR yourself while you seek maintainer comment, as you will later be able to reopen the PR yourself.

@github-actions github-actions bot added the Stale label Mar 4, 2026
@FalloutFalcon FalloutFalcon marked this pull request as ready for review March 6, 2026 06:31
@FalloutFalcon FalloutFalcon requested a review from a team as a code owner March 6, 2026 06:31
@github-actions github-actions bot removed the Stale label Mar 7, 2026
// DARKPACK EDIT ADD START
if(HAS_TRAIT(user, TRAIT_PALE_AURA))
apparent_blood_volume -= (BLOOD_VOLUME_NORMAL * 0.25)
/* I need a citation on if this thing is real, i got nothing.
Copy link
Copy Markdown
Contributor

@LucifersCoils LucifersCoils Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not as code literate as I could be - is this a misnomer for Deceptive Aura?

Image

Page 493, V20 core rulebook?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions github-actions bot added the UI label Mar 23, 2026
@FalloutFalcon
Copy link
Copy Markdown
Member Author

Accidentally made commits from #799 here because it didn't create a new branch and i didn't notice. Gonna make it a dependency cause its prob gonna get merged first and i dont care to revert the commits lol.

Copy link
Copy Markdown
Contributor

@chazzyjazzy chazzyjazzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor shit

list(/datum/quirk/settler, /datum/quirk/freerunning),
list(/datum/quirk/numb, /datum/quirk/selfaware),
list(/datum/quirk/empath, /datum/quirk/evil),
list(/datum/quirk/darkpack/weak_willed, /datum/quirk/darkpack/untamable), // DARKPACK EDIT ADD - MERITS/FLAWS
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this necessary? none of the other darkpack merits/flaws are in this list

Comment on lines +433 to +434
"TRAIT_METAMORPH" = TRAIT_METAMORPH, // DARKPACK EDIT ADD - MERITS/FLAWS
"TRAIT_PIERCED_VEIL" = TRAIT_PIERCED_VEIL, // DARKPACK EDIT ADD - MERITS/FLAWS
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not alphabetically organized

"TRAIT_CHARMER" = TRAIT_CHARMER, // DARKPACK EDIT ADD
"TRAIT_COFFIN_THERAPY" = TRAIT_COFFIN_THERAPY, // DARKPACK EDIT ADD
"TRAIT_COLD_AURA" = TRAIT_COLD_AURA, // DARKPACK EDIT ADD
"TRAIT_PALE_AURA" = TRAIT_PALE_AURA, // DARKPACK EDIT ADD - MERITS/FLAWS
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alphabetical organization?

"TRAIT_VTM_CLANS" = TRAIT_VTM_CLANS, // DARKPACK EDIT ADD
"TRAIT_VTM_MORALITY" = TRAIT_VTM_MORALITY, // DARKPACK EDIT ADD
"TRAIT_WARM_AURA" = TRAIT_WARM_AURA, // DARKPACK EDIT ADD
"TRAIT_DECEPTIVE_AURA" = TRAIT_DECEPTIVE_AURA, // DARKPACK EDIT ADD
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alphabet

Comment on lines +748 to +749
"TRAIT_METAMORPH" = TRAIT_METAMORPH, // DARKPACK EDIT ADD - MERITS/FLAWS
"TRAIT_PIERCED_VEIL" = TRAIT_PIERCED_VEIL, // DARKPACK EDIT ADD - MERITS/FLAWS
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alphabetical sorting in this file/list as well

maximum_value_length = MAX_FLAVOR_LEN

/datum/preference/text/medical/apply_to_human(mob/living/carbon/human/target, value, datum/preferences/preferences)
/datum/preference/text/medical/apply_to_human(mob/living/carbon/human/target, value)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i remember seeing this in ur other pr which has been merged. saw ur comment aswell.


var/mob/parent_mob = parent
if(get_kindred_splat(parent_mob))
if(HAS_TRAIT(parent, TRAIT_PALE_AURA) && !HAS_TRAIT(parent, TRAIT_DECEPTIVE_AURA))
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i just realized - cant they take both quirks in the menu

Comment on lines +113 to +114
if(HAS_TRAIT(target, TRAIT_WEAK_WILLED))
theirpower -= 2
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ur description seems to say that dominate is an auto success but then here its the attackers difficulty on their roll minus two. balance change i assume?

Comment on lines +39 to +40
/datum/discipline_power/temporis/hourglass_of_the_mind/post_gain()
ADD_TRAIT(owner, TRAIT_TIME_SENSE, DISCIPLINE_TRAIT)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might wanna excluded_clans for true brujah if they automatically receive it since people might take this trait and not know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Canon status of the round is not displayed anywhere

3 participants