Conversation
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~7 days. Please address any outstanding review items and ensure your PR is finished - if both are true, and you have auto-staled anyway, you need to actively ask maintainers (by pinging them in the /tg/station Discord) to (re)review or merge your PR. If no maintainer responds to your request, you may wish to close this PR yourself while you seek maintainer comment, as you will later be able to reopen the PR yourself. |
…o some-wolf-traits
| // DARKPACK EDIT ADD START | ||
| if(HAS_TRAIT(user, TRAIT_PALE_AURA)) | ||
| apparent_blood_volume -= (BLOOD_VOLUME_NORMAL * 0.25) | ||
| /* I need a citation on if this thing is real, i got nothing. |
There was a problem hiding this comment.
Clarified some aura things further here: https://discord.com/channels/1393132000583618701/1396599047128617010/1483188208551330035
modular_darkpack/modules/merits_flaws/code/neutral_quirks/illegal_identity.dm
Show resolved
Hide resolved
…o some-wolf-traits
|
Accidentally made commits from #799 here because it didn't create a new branch and i didn't notice. Gonna make it a dependency cause its prob gonna get merged first and i dont care to revert the commits lol. |
…o some-wolf-traits
| list(/datum/quirk/settler, /datum/quirk/freerunning), | ||
| list(/datum/quirk/numb, /datum/quirk/selfaware), | ||
| list(/datum/quirk/empath, /datum/quirk/evil), | ||
| list(/datum/quirk/darkpack/weak_willed, /datum/quirk/darkpack/untamable), // DARKPACK EDIT ADD - MERITS/FLAWS |
There was a problem hiding this comment.
is this necessary? none of the other darkpack merits/flaws are in this list
| "TRAIT_METAMORPH" = TRAIT_METAMORPH, // DARKPACK EDIT ADD - MERITS/FLAWS | ||
| "TRAIT_PIERCED_VEIL" = TRAIT_PIERCED_VEIL, // DARKPACK EDIT ADD - MERITS/FLAWS |
There was a problem hiding this comment.
not alphabetically organized
| "TRAIT_CHARMER" = TRAIT_CHARMER, // DARKPACK EDIT ADD | ||
| "TRAIT_COFFIN_THERAPY" = TRAIT_COFFIN_THERAPY, // DARKPACK EDIT ADD | ||
| "TRAIT_COLD_AURA" = TRAIT_COLD_AURA, // DARKPACK EDIT ADD | ||
| "TRAIT_PALE_AURA" = TRAIT_PALE_AURA, // DARKPACK EDIT ADD - MERITS/FLAWS |
There was a problem hiding this comment.
alphabetical organization?
| "TRAIT_VTM_CLANS" = TRAIT_VTM_CLANS, // DARKPACK EDIT ADD | ||
| "TRAIT_VTM_MORALITY" = TRAIT_VTM_MORALITY, // DARKPACK EDIT ADD | ||
| "TRAIT_WARM_AURA" = TRAIT_WARM_AURA, // DARKPACK EDIT ADD | ||
| "TRAIT_DECEPTIVE_AURA" = TRAIT_DECEPTIVE_AURA, // DARKPACK EDIT ADD |
| "TRAIT_METAMORPH" = TRAIT_METAMORPH, // DARKPACK EDIT ADD - MERITS/FLAWS | ||
| "TRAIT_PIERCED_VEIL" = TRAIT_PIERCED_VEIL, // DARKPACK EDIT ADD - MERITS/FLAWS |
There was a problem hiding this comment.
alphabetical sorting in this file/list as well
| maximum_value_length = MAX_FLAVOR_LEN | ||
|
|
||
| /datum/preference/text/medical/apply_to_human(mob/living/carbon/human/target, value, datum/preferences/preferences) | ||
| /datum/preference/text/medical/apply_to_human(mob/living/carbon/human/target, value) |
There was a problem hiding this comment.
i remember seeing this in ur other pr which has been merged. saw ur comment aswell.
|
|
||
| var/mob/parent_mob = parent | ||
| if(get_kindred_splat(parent_mob)) | ||
| if(HAS_TRAIT(parent, TRAIT_PALE_AURA) && !HAS_TRAIT(parent, TRAIT_DECEPTIVE_AURA)) |
There was a problem hiding this comment.
i just realized - cant they take both quirks in the menu
| if(HAS_TRAIT(target, TRAIT_WEAK_WILLED)) | ||
| theirpower -= 2 |
There was a problem hiding this comment.
ur description seems to say that dominate is an auto success but then here its the attackers difficulty on their roll minus two. balance change i assume?
| /datum/discipline_power/temporis/hourglass_of_the_mind/post_gain() | ||
| ADD_TRAIT(owner, TRAIT_TIME_SENSE, DISCIPLINE_TRAIT) |
There was a problem hiding this comment.
might wanna excluded_clans for true brujah if they automatically receive it since people might take this trait and not know

About The Pull Request
Assorted merits and flaws from W20. (some overlap with V20) Also grabbed pale aura cause it was really easy.
Had to fix some stuff relating to
SPLAT_NONEwith how quirks are handled but that's not even chaz's fault the code is just obtuse (this is my fault mostly)Fixes #693
Why It's Good For The Game
merits for wolves (and others)
Changelog
🆑
add: Adds the merits: Time Sense, Fair Glabro, Metamorph, Untamable, Pale aura, Deceptive Aura
add: Adds the flaws: Animal Musk, One Eye, Weakwilled, Pierced Veil
balance: An accurate display of city time for living mobs is now locked behind time sense.
fix: Derangement now appear as a selectable flaw again.
typo: "Your" to "You" in a dominate to_chat
/:cl: