small cleanups, add check that we are not trying store duplicated ids, require ethereum bigint typest to be non-negative #1328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, require ethereum bigint typest to be non-negative
MicahZoltu
approved these changes
Dec 30, 2025
| }, | ||
| serialize: value => { | ||
| if (typeof value !== 'bigint') return { success: false, message: `${typeof value} is not a bigint.`} | ||
| if (value < 0n) return { success: false, message: `${typeof value} is not a non negative bigint.`} |
Contributor
There was a problem hiding this comment.
I know that in the primary consensus protocol there are no negative numbers, but are there really no negative numbers anywhere in the Ethereum JSON-RPC?
Contributor
Author
There was a problem hiding this comment.
not ones that are hex encoded, if there are, there's no standard to encode negative hex numbers I think
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.