ADD helpdesk_project#7
ADD helpdesk_project#7Alberto-Esteban wants to merge 3 commits intoDarioLodeiros:Alberto-Estebanfrom
Conversation
|
Part B done. Review in a3baa56 |
|
|
||
| @classmethod | ||
| class TestHelpdeskTicketProject(common) | ||
| def ticket_in_proyect(cls): |
There was a problem hiding this comment.
all methods (except setup method) use self, not cls
|
|
||
| -button ticket count +1 | ||
| cls.project.write({ | ||
| 'ticket_count': cls-ticket_count+1 |
There was a problem hiding this comment.
X.ticket_count, not X-ticket_count
| -check the count of the button is right | ||
|
|
||
| def test_helpdesk_ticket_project(self): | ||
| self.assertNotEquals(self.ticket.project, '/', |
There was a problem hiding this comment.
when a ticket does not have a project established, the m2o field value is False, nor /, and the m2o field it should not be self.ticket.project... ¿_id?
| 'stage_id': self.stage_closed.id, | ||
| }) | ||
|
|
||
| self.assertequal(self.project_id.ticket_count, |
There was a problem hiding this comment.
makes sense this test?, You set a ticket in project, and check the project ticket count, then, change de ticket state, and again check the project ticket count... Think that you are not checking the number of open tickets, if not the total. If you were checking the open ones the cash should go down one, also the field name should be representative of the state (open_ticket_count for example)
2 participants
@DarioLodeiros can you review?