Skip to content

Conversation

@Dargon789
Copy link
Owner

@Dargon789 Dargon789 commented Dec 30, 2025

da50474
0002c31

Summary by Sourcery

Update CI test workflow to use pnpm and a local forked blockchain node for running tests, and simplify job dependencies in the build and tests workflows.

CI:

  • Replace the dedicated install job with an in-job test workflow that installs pnpm, project dependencies, and runs tests against a local anvil mainnet fork.
  • Remove explicit job dependencies on the former install job from the build and tests workflows.

@codesandbox
Copy link

codesandbox bot commented Dec 30, 2025

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@vercel
Copy link

vercel bot commented Dec 30, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
sequence-js-docs Ready Ready Preview, Comment Dec 30, 2025 5:36pm
sequence-js-web Error Error Dec 30, 2025 5:36pm
sequence.js Ready Ready Preview, Comment Dec 30, 2025 5:36pm
wagmi-project Ready Ready Preview, Comment Dec 30, 2025 5:36pm

@gemini-code-assist
Copy link

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@sourcery-ai
Copy link

sourcery-ai bot commented Dec 30, 2025

Reviewer's Guide

Refactors the GitHub Actions CI workflow by replacing the separate install job with an integrated test job that installs pnpm dependencies, starts a local anvil blockchain node, and runs tests, while simplifying build and tests jobs’ dependencies.

File-Level Changes

Change Details Files
Replace the separate dependency-install job with an integrated test job that sets up pnpm, installs dependencies, runs a local blockchain node, and executes tests.
  • Remove the standalone install job and its dependency links from other jobs
  • Introduce a new test job that installs pnpm via corepack, installs project dependencies from the correct package directory, and runs the test suite with pnpm
  • Add steps to start an anvil local blockchain node forked from mainnet and wait for it to become available before running tests
.github/workflows/tests.yml
Simplify build and tests jobs to no longer depend on a prior install job.
  • Remove needs: [install] from the build job so it can run independently
  • Remove needs: [install] from the tests job to decouple it from the removed install job
.github/workflows/tests.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@snyk-io
Copy link

snyk-io bot commented Dec 30, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Repository owner deleted a comment from vercel bot Dec 30, 2025
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The new test job YAML looks mis-indented (e.g., steps and the - name: entries are not aligned like in the other jobs), which will likely cause the workflow to be invalid—mirror the structure used in the build/tests jobs.
  • In the Install pnpm step you're using single & between commands instead of &&; this will background commands rather than failing fast on error—use && to ensure setup stops on failures.
  • The working-directory: ./correct-path-to-package-json value looks like a placeholder; set this to the actual path so dependency installation runs in the right project directory.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The new `test` job YAML looks mis-indented (e.g., `steps` and the `- name:` entries are not aligned like in the other jobs), which will likely cause the workflow to be invalid—mirror the structure used in the `build`/`tests` jobs.
- In the `Install pnpm` step you're using single `&` between commands instead of `&&`; this will background commands rather than failing fast on error—use `&&` to ensure setup stops on failures.
- The `working-directory: ./correct-path-to-package-json` value looks like a placeholder; set this to the actual path so dependency installation runs in the right project directory.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Repository owner deleted a comment from vercel bot Dec 30, 2025
@Dargon789 Dargon789 merged commit f2fd08b into master Dec 30, 2025
15 of 21 checks passed
@Dargon789 Dargon789 deleted the v2 branch December 30, 2025 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants