VSL-251: Refactor how we use localstorage and initialize treasury state #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…acts. fix '1 of1' issue.
mannynotfound
approved these changes
Oct 26, 2022
Contributor
mannynotfound
left a comment
mannynotfound
left a comment
There was a problem hiding this comment.
looks really good to me! just a few code suggestions but overall much improved
Co-authored-by: Manny404 <manny@art404.com>
Co-authored-by: Manny404 <manny@art404.com>
|
Looks great! One tiny FE feedback: can we reduce the line height on the text where it says "Some Random Address". First time seeing it on 2 lines. Inspecting the code, it looks like the text size is 2.5rem. If so, can we go with 3rem for line height? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes issues with React state not updating if user navigates away before transactions execute.
We are now only using local storage for address aliases, treasury address aliases, and contacts. All information about the treasury is fetched via a Cadence script on page load.
Demo / Test Result
Load Safe
https://user-images.githubusercontent.com/5679866/197901613-98d85ef4-a5b2-47a1-8627-408bbc7334fc.mov
Add Owner Flow
Peek at LocalStorage
