Skip to content

Update for recent ruby and gem versions #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DannyBen merged 1 commit into from
Feb 6, 2025
Merged

Update for recent ruby and gem versions #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
runs-on: ubuntu-latest

strategy:
matrix: { ruby: ['3.1', '3.2', '3.3'] }
matrix: { ruby: ['3.1', '3.2', '3.3', '3.4'] }

steps:
- name: Check out code
Expand Down
6 changes: 1 addition & 5 deletions spec/approvals/cli/render/svg-code.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
6 changes: 1 addition & 5 deletions spec/approvals/cli/render/watch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
Watching spec/fixtures/render/pacman_dsl.rb for changes
<svg width="140" height="100" style="background:#ddd"
xmlns="http://www.w3.org/2000/svg"
xmlns:xlink="http://www.w3.org/1999/xlink">

<svg width="140" height="100" style="background:#ddd" xmlns="http://www.w3.org/2000/svg">

<rect x="10" y="10" width="120" height="80" rx="10" fill="#666"/>
<circle cx="50" cy="50" r="30" fill="yellow"/>
Expand All @@ -11,5 +8,4 @@ Watching spec/fixtures/render/pacman_dsl.rb for changes
<circle cx="80" cy="50" r="4" fill="yellow"/>
<circle cx="98" cy="50" r="4" fill="yellow"/>
<circle cx="116" cy="50" r="4" fill="yellow"/>

</svg>
5 changes: 5 additions & 0 deletions victor-cli.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,11 @@ Gem::Specification.new do |s|
s.add_dependency 'requires', '~> 1.0'
s.add_dependency 'rufo', '~> 0.12'
s.add_dependency 'victor', '~> 0.4'

# FIXME: Remove when resolved.
# This is a sub-dependency of filewatcher which does not bundle logger.
# ref: https://github.com/filewatcher/filewatcher/pull/272
s.add_dependency 'logger', '~> 1.6'

s.metadata = {
'bug_tracker_uri' => 'https://github.com/DannyBen/victor-cli/issues',
Expand Down