Skip to content

fix: probably fix cwe-1333 #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Dankoy wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: probably fix cwe-1333 #165

Dankoy wants to merge 3 commits into from

Conversation

@Dankoy
Copy link
Owner

@Dankoy Dankoy commented Jan 4, 2025

Description

Probably fixes cwe-1333

Fixes cwe-1333

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • It wasn't

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have updated project version if release is planned

@Dankoy Dankoy added the bug Something isn't working label Jan 4, 2025
@Dankoy Dankoy self-assigned this Jan 4, 2025
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 4, 2025
View reviewed changes
...criptionsholder/subscriptions_holder/core/service/searchparser/SearchCriteriaParserImpl.java
search = search + ",";

Pattern pattern = Pattern.compile("(\\w+?)([:<>])(\\w+?),");
Matcher matcher = pattern.matcher(search);

Check failure

Code scanning / CodeQL

Polynomial regular expression used on uncontrolled data High

This
regular expression
Loading
that depends on a
user-provided value
Loading
may run slow on strings with many repetitions of 'a'.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Dankoy Dankoy

Labels

bug Something isn't working

Projects

@Dankoy's jforwarder
Status: No status

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Dankoy