Avoid cloning AST nodes when collecting symbols #1086
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1049
It avoids cloning the AST nodes when collecting symbols.
Previously the files were parsed using a temporary allocator, and then cloned to a collection allocator when collecting symbols.
Now the file is parsed using the collection allocator directly, and then just the strings in the AST are copied to the collection allocator later—the source code is freed after the request.
This works quite well and even makes tests run faster for me—from ~950ms to ~800ms.